Skip to content

Infer same directory dependencies for Thrift (Closes #15152) - #23618

Open
coderay3000 wants to merge 1 commit into
pantsbuild:mainfrom
coderay3000:fix-thrift-same-dir-inference
Open

Infer same directory dependencies for Thrift (Closes #15152)#23618
coderay3000 wants to merge 1 commit into
pantsbuild:mainfrom
coderay3000:fix-thrift-same-dir-inference

Conversation

@coderay3000

Copy link
Copy Markdown

Problem

Thrift dependency inference was failing to infer dependencies on other Thrift files residing in the same directory when included without explicit relative paths, leading to unresolved dependency warnings or missing targets.

Solution

  • Updated infer_thrift_dependencies in dependency_inference.py to resolve same-directory includes alongside standard module mapping.
  • Added test_infer_same_directory_dependency in dependency_inference_test.py to ensure same-directory Thrift files are correctly inferred as target dependencies.

Result

Same-directory Thrift includes are now automatically inferred, improving dependency resolution for Thrift source targets.

Closes #15152

@coderay3000
coderay3000 force-pushed the fix-thrift-same-dir-inference branch from 43f2253 to 483206f Compare August 11, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

thrift: infer same directory dependencies

1 participant