Skip to content

Create previews for components#55

Draft
nicolas-brousse wants to merge 13 commits into
mainfrom
component-previews
Draft

Create previews for components#55
nicolas-brousse wants to merge 13 commits into
mainfrom
component-previews

Conversation

@nicolas-brousse

@nicolas-brousse nicolas-brousse commented Sep 11, 2021

Copy link
Copy Markdown
Member
  • Use latest version of lookbook
  • All previews
  • Include TestHelper to have builder object?

  • Maybe create two combustion app path, one for test, one for development
  • Confirm the gem should append preview path in Rails engine

To test run puma, then load http://localhost:9292

Closes #52

@nicolas-brousse nicolas-brousse added the enhancement New feature or request label Sep 11, 2021
@nicolas-brousse nicolas-brousse added this to the v0.2 milestone Sep 11, 2021
@nicolas-brousse nicolas-brousse self-assigned this Sep 11, 2021
@nicolas-brousse nicolas-brousse changed the title wip Create previews for components Sep 11, 2021
@nicolas-brousse

Copy link
Copy Markdown
Member Author

@Spone small wip :)

@Spone Spone modified the milestones: v0.2, v0.3 Sep 16, 2021
@Spone Spone force-pushed the component-previews branch from 8f80083 to 6bde654 Compare February 6, 2023 23:23
@Spone

Spone commented Feb 6, 2023

Copy link
Copy Markdown
Collaborator

@nicolas-brousse I rebased and fixed the specs.

But I'm not sure how to start the server locally, here is the output:

$ bundle exec puma       
Puma starting in single mode...
* Puma version: 6.0.2 (ruby 3.1.3-p185) ("Sunflower")
*  Min threads: 0
*  Max threads: 5
*  Environment: development
*          PID: 346882
! Unable to load application: NameError: uninitialized constant Rails

    class Engine < ::Rails::Engine
                   ^^^^^^^
bundler: failed to load command: puma (/home/hans/.asdf/installs/ruby/3.1.3/bin/puma)
/home/hans/projects/vc/view_component-form/lib/view_component/form/engine.rb:6:in `<module:Form>': uninitialized constant Rails (NameError)

    class Engine < ::Rails::Engine
                   ^^^^^^^
	from /home/hans/projects/vc/view_component-form/lib/view_component/form/engine.rb:4:in `<module:ViewComponent>'
	from /home/hans/projects/vc/view_component-form/lib/view_component/form/engine.rb:3:in `<top (required)>'
	[... truncated]

@nicolas-brousse

Copy link
Copy Markdown
Member Author

@Spone I did a small change

@pantographe pantographe deleted a comment from Dre-AsiliVentures Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create preview for components

2 participants