Repository navigation
build: require rector/rector ^2.8.4 - #444
Merged
Merged
Conversation
5 tasks
Collaborator
Author
|
I've been testing this on project analysis and a few local projects, and this seems to clear everything up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Raises the minimum Rector to 2.8.4, the first release with the scoper fix (rectorphp/rector-src#8897) that stops
withComposerBased(drupal: true)from fataling withClass "RectorPrefix…\DrupalRector\Set\DrupalSetList" not found. 2.8.4 also contains #8881, which #443 already adapted to.Changes the
^2.6.5constraint to^2.8.4incomposer.json,phpunit.yml,phpstan.yml, and the requirement notes inCHANGELOG.mdandREADME.md.The README warning that
withComposerBased(drupal: true)fatals is left in place on purpose. It gets rewritten after the re-test on a Drupal 11 site, as a follow-up under #441.To Test
699 tests and PHPStan pass on Rector 2.8.4.
Related: #441
🤖 Generated with Claude Code
https://claude.ai/code/session_01EY2u2uXHmnxb88Rk1KcG6a