-
Notifications
You must be signed in to change notification settings - Fork 218
fix: remove hard requirements on active_support and webmock #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Saup21
wants to merge
10
commits into
master
Choose a base branch
from
fix/remove-active-support-webmock-hard-requirements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+106
−1
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
787727b
fix: remove hard requirements on active_support and webmock
Saup21 1c99c72
refactor: use require instead of require_relative for pact/support/blank
Saup21 bfce698
fix: add deep_dup polyfill alongside blank?/present?
Saup21 f463cc5
refactor: rename blank.rb to core_ext.rb
Saup21 4248f57
docs: update pact.rb comment to reflect core_ext scope
Saup21 9cd0773
fix: correct Object#blank? and Object#present? polyfill implementations
Saup21 08f34c2
chore: add presence method to Object polyfill (for non activesupport)
YOU54F 3fde9f8
fix: align core_ext polyfills more closely with active_support implem…
Saup21 8517571
fix(example): remove combustion dependency from examples
Saup21 9c3023b
Revert "fix(example): remove combustion dependency from examples"
Saup21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # Minimal active_support polyfills for blank?/present? and deep_dup. | ||
| # Each block is skipped entirely if the method is already defined | ||
| # (e.g. active_support is loaded by the host application). | ||
|
|
||
| unless Object.method_defined?(:blank?) | ||
| class NilClass | ||
| def blank? = true | ||
| def present? = false | ||
| end | ||
|
|
||
| class FalseClass | ||
| def blank? = true | ||
| def present? = false | ||
| end | ||
|
|
||
| class TrueClass | ||
| def blank? = false | ||
| def present? = true | ||
| end | ||
|
|
||
| class String | ||
| BLANK_RE = /\A[[:space:]]*\z/ | ||
|
|
||
| def blank? | ||
| empty? || BLANK_RE.match?(self) | ||
| end | ||
|
|
||
| def present? = !blank? | ||
| end | ||
|
|
||
| class Symbol | ||
| alias_method :blank?, :empty? | ||
| def present? = !blank? | ||
| end | ||
|
|
||
| class Array | ||
| alias_method :blank?, :empty? | ||
| def present? = !empty? | ||
| end | ||
|
|
||
| class Hash | ||
| alias_method :blank?, :empty? | ||
| def present? = !empty? | ||
| end | ||
|
|
||
| class Object | ||
| def blank? = respond_to?(:empty?) ? !!empty? : false | ||
| def present? = !blank? | ||
|
|
||
| def presence | ||
| self if present? | ||
| end | ||
| end | ||
| end | ||
|
|
||
| unless Object.method_defined?(:deep_dup) | ||
| class Object | ||
| def deep_dup | ||
| dup | ||
| rescue TypeError | ||
| self | ||
| end | ||
| end | ||
|
|
||
| class Array | ||
| def deep_dup | ||
| map(&:deep_dup) | ||
| end | ||
| end | ||
|
|
||
| class Hash | ||
| def deep_dup | ||
| hash = dup | ||
| each_pair do |key, value| | ||
| if ::String === key || ::Symbol === key | ||
| hash[key] = value.deep_dup | ||
| else | ||
| hash.delete(key) | ||
| hash[key.deep_dup] = value.deep_dup | ||
| end | ||
| end | ||
| hash | ||
| end | ||
| end | ||
|
|
||
| class Module | ||
| def deep_dup | ||
| name.nil? ? super : self | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.