Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions specfile/sanitizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,12 @@ def normalize_macro(expr):
return None
return expr

def normalize_literal(expr):
expr = strip_quotes(expr.strip())
if not expr or re.search(r"[%{}]", expr):
return None
return f"%{{quote:{expr}}}"

def is_safe_for_expand(s):
return not re.search(r"%(\{\w+[\s:]|\(|\[)", s)

Expand Down Expand Up @@ -709,7 +715,7 @@ def convert_glob_removal(expr, op, pat):
# --- echo EXPR | CMD (pipe pattern) ---
m = _RE_PIPE.match(body)
if m:
expr = normalize_macro(m.group(1))
expr = normalize_macro(m.group(1)) or normalize_literal(m.group(1))
if expr is not None:
cmd = m.group(2).strip()
result = convert_string_op(expr, cmd)
Expand All @@ -720,7 +726,7 @@ def convert_glob_removal(expr, op, pat):
m = _RE_HERESTRING.match(body)
if m:
cmd = m.group(1).strip()
expr = normalize_macro(m.group(2))
expr = normalize_macro(m.group(2)) or normalize_literal(m.group(2))
if expr is not None:
result = convert_string_op(expr, cmd)
if result:
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/test_sanitizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,10 @@ def test_pipe_to_tr(body, expected):
"echo %{unversion} | sed 's/_/./g'",
'%{lua:print((rpm.expand("%{unversion}"):gsub("_", ".")))}',
),
(
"echo 1.2.3-rc4 | sed 's/-/~/g'",
'%{lua:print((rpm.expand("%{quote:1.2.3-rc4}"):gsub("-", "~")))}',
),
],
)
def test_pipe_to_sed(body, expected):
Expand Down Expand Up @@ -390,6 +394,10 @@ def test_pipe_to_awk(body, expected):
"sed 's/\\.//g' <<<%{version}",
'%{lua:print((rpm.expand("%{version}"):gsub("%.", "")))}',
),
(
"sed 's/-/~/g' <<<1.2.3-rc4",
'%{lua:print((rpm.expand("%{quote:1.2.3-rc4}"):gsub("-", "~")))}',
),
],
)
def test_herestring(body, expected):
Expand Down
Loading