fix: refresh Cargo.lock for modern Rust and align toolchain#43
Open
hgp22 wants to merge 3 commits intop4lang:mainfrom
Open
fix: refresh Cargo.lock for modern Rust and align toolchain#43hgp22 wants to merge 3 commits intop4lang:mainfrom
hgp22 wants to merge 3 commits intop4lang:mainfrom
Conversation
hgp22
commented
Apr 27, 2026
- Update locked time and wasm-bindgen stack (fixes E0282 in time and wasm-bindgen compatibility with current rustc)
- Set workspace resolver = 2; require wasm-bindgen >= 0.2.88 in p4-analyzer-wasm
- Pin rust-toolchain to 1.88.0 (lockfile v4, updated deps, wasm-bindgen-cli)
- CI: Rust 1.88.0 with wasm32-unknown-unknown target
- Fix test_pp! macro for semicolon_in_expressions_from_macros (Rust 1.95+)
- Nx build-nix: portable runtime input (Node) instead of GNU stat for macOS
Contributor
|
Could you sign the DCO and rebase please? |
Author
|
i added some changes to the lsp other than refreshing the tollchains and locks, i will remove those changes and ask for review. |
e3e9802 to
de7ee85
Compare
- Update locked time and wasm-bindgen stack (fixes E0282 in time and wasm-bindgen compatibility with current rustc) - Set workspace resolver = 2; require wasm-bindgen >= 0.2.88 in p4-analyzer-wasm - Pin rust-toolchain to 1.88.0 (lockfile v4, updated deps, wasm-bindgen-cli) - CI: Rust 1.88.0 with wasm32-unknown-unknown target - Fix test_pp! macro for semicolon_in_expressions_from_macros (Rust 1.95+) - Nx build-nix: portable runtime input (Node) instead of GNU stat for macOS Signed-off-by: hgp22 <henriquepereira31337@gmail.com>
Fixes "lock file needs to be updated" with --locked on Rust 1.88. Signed-off-by: hgp22 <henriquepereira31337@gmail.com>
LspProtocolMachine::new was called with self.file_system.clone().unwrap(), so WASM (and any host with None) panicked. Pass the same Arc used for run_protocol_machine (the default LspEnumerableFileSystem or injected FS). Signed-off-by: hgp22 <henriquepereira31337@gmail.com>
de7ee85 to
97b7bd8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.