feat: only update one button at a time #122#177
Open
lingo wants to merge 2 commits intop-e-w:masterfrom
Open
Conversation
added 2 commits
September 5, 2025 21:52
When changes occur in the directory, this only updates the buttons for scripts that have altered, rather than removing and adding all buttons. This allows for updating a single button. However this system can cause buttons with the same position numbering to change position in an unstable manner
Prevent changing of position in an unstable manner
Author
|
Added improvement to avoid the unstable changes in position. |
Collaborator
|
The basic idea is nice, but the unstable behavior is not. Also, please note that argos is basically in maintenance mode as the original author has left the project. I'm doing kind of minimal maintainance (making sure that it still works with current GNOME versions) but I'm rather conservative with larger changes like this. |
Author
|
My most recent change avoids the unstable behaviour. Also, I had not realised this about the original author.; perhaps worth putting a notice at the top of the README with a link to the issue, which I've now seen. For now my branch is working well for me at least on my local machine, I'll catch up on the discussion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When changes occur in the directory, this only updates the buttons for scripts that have altered, rather than removing and adding all buttons.
This allows for updating a single button.
However this system can cause buttons with the same position numbering to change position in an unstable manner; I can't see how to avoid this at present.(Fixed in latest version)