Skip to content

fix: apply rules table query params after hydration#1133

Draft
camc314 wants to merge 1 commit into
mainfrom
codex/fix-rules-query-links
Draft

fix: apply rules table query params after hydration#1133
camc314 wants to merge 1 commit into
mainfrom
codex/fix-rules-query-links

Conversation

@camc314

@camc314 camc314 commented May 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Apply the rules table query parameters after client mount instead of during client setup.
  • Avoid SSR/client hydration mismatch that could leave filtered row labels paired with stale href attributes from the unfiltered table order.

Issue Screenshot

Bad rules links with scope query params

Validation

  • vp install
  • vp check
  • vp run build
  • git diff --check
  • Browser verification on http://127.0.0.1:5173/docs/guide/usage/linter/rules.html?sort=name&dir=asc&scope=node

vp test currently fails before running tests due to an existing Cloudflare Vite plugin startup incompatibility with resolve.external.

@netlify

netlify Bot commented May 25, 2026

Copy link
Copy Markdown

Deploy Preview for oxc-project ready!

Name Link
🔨 Latest commit 0dc1a73
🔍 Latest deploy log https://app.netlify.com/projects/oxc-project/deploys/6a1486274cf2e70008669680
😎 Deploy Preview https://deploy-preview-1133--oxc-project.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@camc314 camc314 self-assigned this May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant