Repository navigation
chore(tests): fail the PHP unit tests if deprecations are reported - #860
Merged
Merged
Conversation
We want to know if the code is emitting PHP deprecation messages. These can end up in the log file, swamping it with messages. Set convertDeprecationsToExceptions to true. Signed-off-by: Phillip Davis <phil@jankaritech.com>
|
|
phil-davis
force-pushed
the
php-deprecations
branch
2 times, most recently
from
November 5, 2026 03:32
e342ec6 to
da97c4d
Compare
- declare private variables to avoid Creation of dynamic property is deprecated - pass the empty string rather than null to various string functions Signed-off-by: Phillip Davis <phil@jankaritech.com>
phil-davis
force-pushed
the
php-deprecations
branch
from
November 5, 2026 04:01
da97c4d to
0d6228f
Compare
If the cache key value is null, then set it to the empty string for passing to base64_decode. Signed-off-by: Phillip Davis <phil@jankaritech.com>
Contributor
Author
|
The changes in the 2nd commit were found as a result of the PHP unit tests failing when the unit test config The 3rd commit fixes the deprecation report in issue #859 It needs unit test coverage. I started adding a test cases(s) to |
jvillafanez
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to know if the code is emitting PHP deprecation messages. These can end up in the log file, swamping it with messages.
Set convertDeprecationsToExceptions to true.
Similar to what was done in core PR owncloud/core#41694
Fixes #859