[DC-216] finish the item actions including the context menu #12441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implemented the menu - the actions need more testing but so far it seems to work fine also fixed a bug in folderman related to incorrect unsynced count when user adds folder
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
a few more tweaks and cleanup started adding some handling for the enable/disable vfs action. this has led to some extra refactoring so I want to commit this controller related stuff as a separate step - it may not build but better than munging all of this stuff into one commit I think.
killed deadwood renamed Vfs::checkAvailability and changed return type to simple string updated callers and added copious todo's related to this topic of having local paths that don't support vfs even when vfs is otherwise available. See DC-219 for that
missed folderman on last push
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-216