Fix(scheduleTick): Skip Deprecated ScheduleResourceTick on FiveM Enhanced - #291
Closed
solaire-fivem wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a check inside
scheduleTickif the server build is FiveM enhanced by checking the server's convar value if the server is detected as running on GTA enhanced it returns early. FiveM enhanced phased out theScheduleResourceTickand now all servers run on the same tick so it is not needed.I originally tried using the new native
IsGameEnhancedVersionbut sadly that is a client sided native so getting the game convar was the best solution I had found. I do not know how ox are doing the enhanced migration if you are making a new branch etc so I've left it targetting main from now on.Testing