fix(profiler): handle databases that do not support query profiling - #285
Open
areomr wants to merge 1 commit into
Open
fix(profiler): handle databases that do not support query profiling#285areomr wants to merge 1 commit into
areomr wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some MySQL-protocol compatible databases (such as TiDB) accept
SET profiling = 1statements without error but do not implement the legacyINFORMATION_SCHEMA.PROFILINGtable. Previously, this caused queries to crash whenmysql_debugwas enabled.This commit introduces a fallback mechanism:
try...catchblock around profiling statements to gracefully handle unsupported databases.profilerSupportedstate to cache whether the profiler is available. This prevents throwing errors on every subsequent query and instead skips straight to the fallback timing path.