Skip to content

[nit] Make protocol errors more typed and idiomatic. - #114

Open
zeonzip wants to merge 2 commits into
outpoot:mainfrom
zeonzip:main
Open

[nit] Make protocol errors more typed and idiomatic.#114
zeonzip wants to merge 2 commits into
outpoot:mainfrom
zeonzip:main

Conversation

@zeonzip

@zeonzip zeonzip commented Sep 25, 2025

Copy link
Copy Markdown

Small DX/QoL cleanup; make GURT protocol lib's errors (GurtError) more directly typed as more idiomatic in rust style and remove redundant methods for GurtError.

@vercel

vercel Bot commented Sep 25, 2025

Copy link
Copy Markdown

@zeonzip is attempting to deploy a commit to the facehh's projects Team on Vercel.

A member of the Team first needs to authorize it.

@zeonzip

zeonzip commented Sep 26, 2025

Copy link
Copy Markdown
Author

This pr would also fit in with the eventual pr for issue #108 by replacing e.g GurtError::crypto(CryptoError::SomeError) with GurtError::Crypto(CryptoError::someError).

@face-hh

face-hh commented Sep 28, 2025

Copy link
Copy Markdown
Member

i believe this PR should also fix the breaking changes in gurtlib-reliant subprojects

@zeonzip

zeonzip commented Sep 29, 2025

Copy link
Copy Markdown
Author

believe this PR should also fix the breaking changes in gurtlib-reliant subprojects

I'll do that then, but to also ensure other 3rd party libraries gets a heads up, we could also keep the construction methods but mark them as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants