Repository navigation
fix: read the default Honcho URL at runtime and release dashboard v1.2.3 - #13
Merged
Merged
Conversation
Safari rasterizes SVG filters at low resolution in small <img> elements, which smeared the header logo on iPhone. Draw the cyan and pink shadow layers as offset copies of the face instead of a drop-shadow filter. The 650px render matches the original apart from hard shadow edges.
next build inlines NEXT_PUBLIC_HONCHO_BASE_URL into server code too, so the published image ignored HONCHO_BASE_URL: the proxy fell back to http://localhost:8000 and new browsers were seeded with it. - Resolve the default target from runtime env (HONCHO_PROXY_BASE_URL, then the runtime NEXT_PUBLIC_HONCHO_BASE_URL, then the build-time value) for the proxy fallback. - Render the root layout per request and pass the default to the browser in a meta tag, so new browsers and the NEW_INSTANCE form start on the configured Honcho. - Move an untouched default/local seed that still holds the build-time URL to the runtime default. Edited instances are never changed. - Keep every previously allowed proxy target allowed. - Update the compose template, env examples, Dockerfile, README and AGENTS.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published image ignored
HONCHO_BASE_URLat runtime.next buildinlinesprocess.env.NEXT_PUBLIC_*into server code as well as browser code, so the proxy fell back tohttp://localhost:8000and every new browser was seeded with it. A phone opening the dashboard over Tailscale or a new LAN address showedHTTP 502: Upstream fetch faileduntil the instance was set by hand under CONFIG.HONCHO_PROXY_BASE_URL, then runtimeNEXT_PUBLIC_HONCHO_BASE_URL, then the build-time value) for the proxy fallback.default/localseed that still holds the build-time URL to the runtime default. Edited instances are never changed.Compatibility
Compared against the published 1.2.2 image across five env setups (template with
HONCHO_BASE_URLunset or set,HONCHO_PROXY_BASE_URLonly, allowlist only, no env). Every proxy response matched 1.2.2 except the configured-default case that used to return 502, which now returns 200.Test plan
npm run check(58 tests, including 13 new ones inscripts/default-target.test.mjs)