refactor(creatures): move getKillers logic into Player::getCorpse

[ranisalt]

Pull Request Prelude

• I have followed proper The Forgotten Server code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This pull request refactors how killer information is calculated for player death descriptions, removing Creature::getKillers, replacing it with std::ranges::count_if directly in Player::getCorpse. May improve performance by reducing unnecessary copying to an intermediate array.

[Copilot]

Pull request overview

This PR refactors the killer counting logic for player death messages by eliminating the Creature::getKillers() method and replacing it with an inline std::ranges::count_if call directly in Player::getCorpse(). This change reduces unnecessary allocations by counting killers directly instead of building an intermediate vector and then calling .size() on it.

Key Changes:

• Removed Creature::getKillers() method that created and returned a vector of killer creatures
• Replaced with std::ranges::count_if that counts killers directly using the same logic
• Maintains identical behavior while improving performance through elimination of intermediate container allocation

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
src/creature.h	Removed declaration of unused getKillers() method
src/creature.cpp	Removed getKillers() method implementation that created intermediate vector
src/player.cpp	Replaced getKillers().size() with inline std::ranges::count_if to count killers directly

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.