Skip to content

Conversation

@ranisalt
Copy link
Member

Pull Request Prelude

Changes Proposed

This missing forward declaration causes a build error when unity build is disabled:

/home/rsa/Documents/forgottenserver/src/iomapserialize.h:30:54: error: ‘Thing’ has not been declared
   30 |         static bool loadItem(PropStream& propStream, Thing* parent);
      |                                                      ^~~~~

It used to be Cylinder but it was changed in #5058 and the forward declaration wasn't added accordingly.

Issues addressed:

How to test:

@ranisalt ranisalt requested a review from Copilot November 29, 2025 21:19
Copilot finished reviewing on behalf of ranisalt November 29, 2025 21:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a build error that occurs when unity build is disabled by adding the missing forward declaration for the Thing class. The parameter type was changed from Cylinder to Thing in a previous PR (#5058), but the corresponding forward declaration was not updated at that time.

  • Adds class Thing; forward declaration to resolve compilation error
  • Maintains alphabetical ordering of forward declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants