Repository navigation
fix: add missing maturity levels to OSPS-BR-07.01 and OSPS-VM-02.01 - #567
Merged
eddie-knight merged 1 commit intoOct 15, 2026
Merged
Conversation
What/Why Both requirements list only maturity-1, so tools that assess a project at level 2 or 3 skip them. Every other level 1 requirement also lists levels 2 and 3, and nothing replaces these two at higher levels. This is the same gap ossf#223, ossf#225 and ossf#239 fixed for other requirements. Proof it works - `go run . compile` in cmd/ succeeds. - The compiled Gemara catalog passes `cue vet -d '#OSPSBaseline'`. Risk Low. Data-only change that adds two levels to two requirements. No requirement text changes. AI role Claude Opus 5.5 traced the history of both requirements and made the edit. A human reviewed the findings and approved the change. Review focus Whether VM-03.01 is meant to replace VM-02.01 at levels 2 and 3. It assumes security contacts exist but does not require documenting them. Signed-off-by: jmeridth <jmeridth@gmail.com>
trumant
approved these changes
Oct 14, 2026
trumant
left a comment
Contributor
There was a problem hiding this comment.
This makes logical sense to me. Thanks for identifying and proposing a fix for the inconsistency
jmeridth
marked this pull request as ready for review
October 14, 2026 23:40
Contributor
|
Thanks for the patch! +1 |
eddie-knight
approved these changes
Oct 15, 2026
eddie-knight
left a comment
Contributor
There was a problem hiding this comment.
Good catch.
Our approach doesn't leave room for anything to be level 1 only. If it's L1, it's L2 and L3 as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
OSPS-BR-07.01 and OSPS-VM-02.01 list only
maturity-1. Every other level 1 requirement also lists levels 2 and 3. Tools that assess a project at level 2 or 3 skip both, so a level 2 project is never checked for secrets in version control or for documented security contacts. This addsmaturity-2andmaturity-3to both, the same fix as #223, #225 and #239.Proof it works
go run . compileincmd/succeeds, and the compiled Gemara catalog passescue vet -d '#OSPSBaseline'.Risk
Low. Data only: two levels added to two requirements, and no requirement text changes. Projects assessed at level 2 or 3 will now be checked against these two.
AI role
Claude Opus 5.5 traced the history of both requirements and made the edit. I reviewed the findings and the diff.
Review focus
cc @trumant @SecurityCRob