Skip to content

fix: add missing maturity levels to OSPS-BR-07.01 and OSPS-VM-02.01 - #567

Merged
eddie-knight merged 1 commit into
ossf:mainfrom
jmeridth:fix/carry-l1-requirements-to-l2-l3
Oct 15, 2026
Merged

eddie-knight merged 1 commit into
ossf:mainfrom
jmeridth:fix/carry-l1-requirements-to-l2-l3

Conversation

@jmeridth

Copy link
Copy Markdown
Member

What/Why

OSPS-BR-07.01 and OSPS-VM-02.01 list only maturity-1. Every other level 1 requirement also lists levels 2 and 3. Tools that assess a project at level 2 or 3 skip both, so a level 2 project is never checked for secrets in version control or for documented security contacts. This adds maturity-2 and maturity-3 to both, the same fix as #223, #225 and #239.

Proof it works

go run . compile in cmd/ succeeds, and the compiled Gemara catalog passes cue vet -d '#OSPSBaseline'.

Risk

Low. Data only: two levels added to two requirements, and no requirement text changes. Projects assessed at level 2 or 3 will now be checked against these two.

AI role

Claude Opus 5.5 traced the history of both requirements and made the edit. I reviewed the findings and the diff.

Review focus

  • Whether VM-03.01 is meant to replace VM-02.01 at levels 2 and 3. It assumes security contacts exist but doesn't require documenting them. Make explicit when a control builds on an earlier control #423 touches on this.
  • Whether this needs a "Modified controls" entry for the next release. The earlier fixes didn't add one.

cc @trumant @SecurityCRob

What/Why

Both requirements list only maturity-1, so tools that assess a project
at level 2 or 3 skip them. Every other level 1 requirement also lists
levels 2 and 3, and nothing replaces these two at higher levels. This
is the same gap ossf#223, ossf#225 and ossf#239 fixed for other requirements.

Proof it works

- `go run . compile` in cmd/ succeeds.
- The compiled Gemara catalog passes `cue vet -d '#OSPSBaseline'`.

Risk

Low. Data-only change that adds two levels to two requirements. No
requirement text changes.

AI role

Claude Opus 5.5 traced the history of both requirements and made the
edit. A human reviewed the findings and approved the change.

Review focus

Whether VM-03.01 is meant to replace VM-02.01 at levels 2 and 3. It
assumes security contacts exist but does not require documenting them.

Signed-off-by: jmeridth <jmeridth@gmail.com>

@trumant trumant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes logical sense to me. Thanks for identifying and proposing a fix for the inconsistency

@jmeridth
jmeridth marked this pull request as ready for review October 14, 2026 23:40
@SecurityCRob

Copy link
Copy Markdown
Contributor

Thanks for the patch! +1

@eddie-knight eddie-knight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

Our approach doesn't leave room for anything to be level 1 only. If it's L1, it's L2 and L3 as well.

@eddie-knight
eddie-knight merged commit fb138f9 into ossf:main Oct 15, 2026
7 checks passed
@jmeridth
jmeridth deleted the fix/carry-l1-requirements-to-l2-l3 branch October 15, 2026 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants