225 image database modification for multiple image issues - #231
Open
LeahBragg wants to merge 14 commits into
Open
225 image database modification for multiple image issues#231LeahBragg wants to merge 14 commits into
LeahBragg wants to merge 14 commits into
Conversation
5 tasks
…-multiple-image-issues
…mage-issues' of https://github.com/oss-slu/civickit into 225-consider-image-database-modification-for-multiple-image-issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issue #225
Files Added:
backend/src/controllers/image.controller.tsbackend/src/repositories/image.repository.tsbackend/src/routes/image.routes.tsbackend/src/schemas/issue.schema.tsbackend/src/services/image.service.tsmobile/src/api/images.ts- added images apishared/src/enums/image.ts-PhotoSourceenumshared/src/types/image.ts- image typeFiled Modified:
backend/src/controllers/auth.controller.tsbackend/src/controllers/issue.controller.tsbackend/src/controllers/login.controller.tsbackend/src/controllers/org.controller.tsbackend/src/controllers/timeline.controller.tsbackend/src/db/schema.tsbackend/src/repositories/auth.repository.tsbackend/src/repositories/issue.repository.tsbackend/src/repositories/login.repository.tsbackend/src/repositories/timeline.repository.tsbackend/src/server.tsbackend/src/services/auth.service.tsbackend/src/services/issue.service.tsbackend/src/services/login.service.tsbackend/src/services/org.service.tsbackend/src/services/timeline.service.tsmobile/src/api/issues.tsmobile/src/api/index.ts- added images apimobile/src/components/IssueCard.tsxmobile/src/components/TimelineEntry.tsxmobile/src/screens/Misc/IssueDetailScreen.tsxmobile/src/components/SelectedImage.tsx- uses image dimensions to better place the X buttonmobile/src/components/SelectedImageGallery.tsx- sends some metadata toSelectedImagemobile/src/components/Timeline.tsx- determines which timeline entries should be anonymousmobile/src/screens/IssueCreation/CameraScreen.tsx- unmounts when not in use, sends height and width to metadata, image picker dimensions overwrite exif dimensions so that orientation is correctmobile/src/screens/IssueCreation/IssueCreationScreen.tsx- adds images to db before submitting issue to dbmobile/src/utils/photoMetadata.ts- gets metadata for all photos added to an issueshared/src/types/issue.tsshared/src/types/org.tsshared/src/types/user.tsshared/src/types/api.ts- modified types, addedCreateImageDTOTo Test:
Open app as usual, photos should still load as normal. in the issue create screen, X button will be in the top left corner of the photo not the container.