Gleam DependencyHandler #11221
Open
Gleam DependencyHandler #11221
+614
−662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11221 +/- ##
=========================================
Coverage 57.41% 57.41%
Complexity 1705 1705
=========================================
Files 346 346
Lines 12875 12875
Branches 1228 1228
=========================================
Hits 7392 7392
Misses 5005 5005
Partials 478 478
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Use typed enums for Package.SourceType and Requirement.SourceType instead of raw strings like "hex", "git", and "local". This improves type safety and enables exhaustive when expressions. Signed-off-by: Jonatan Männchen <[email protected]>
Replace lazy property with factory function to ensure test isolation. Each test now gets its own Gleam instance instead of sharing one. Signed-off-by: Jonatan Männchen <[email protected]>
Move Link, Repository, and Dependency types inside GleamToml as nested classes. Rename GleamDependency to GleamToml.Dependency and convert findHomepageUrl from extension function to member function. Signed-off-by: Jonatan Männchen <[email protected]>
maennchen
force-pushed
the
sosef/gleam-graph-builder
branch
2 times, most recently
from
390d424 to
b9c3cae
Compare
Remove fields that are parsed but never used by the plugin: - GleamManifest.requirements map and Requirement class - GleamManifest.Package.buildTools and otpApp fields - HexPackageInfo.latestStableVersion field Signed-off-by: Jonatan Männchen <[email protected]>
Use default empty collections for packages and requirements fields, simplifying construction of empty manifests. Signed-off-by: Jonatan Männchen <[email protected]>
Replace scope-based dependency resolution with DependencyGraphBuilder for consistent graph format across package managers. Extract dependency handling logic into GleamDependencyHandler and introduce GleamPackageInfo and GleamProjectContext types to support the new architecture. Signed-off-by: Jonatan Männchen <[email protected]>
maennchen
force-pushed
the
sosef/gleam-graph-builder
branch
2 times, most recently
from
0d23fd4 to
ef2e56d
Compare
Fix isValidLocalPath to use startsWith for checking whether a resolved path is within the working directory. Add test coverage for invalid path dependencies. Signed-off-by: Jonatan Männchen <[email protected]>
maennchen
force-pushed
the
sosef/gleam-graph-builder
branch
from
ef2e56d to
0a91a26
Compare
fviernau
reviewed
Dec 13, 2025
| private fun isValidLocalPath(workingDir: File, path: String): Boolean { | ||
| val resolvedPath = workingDir.resolve(path).canonicalFile | ||
| return resolvedPath.relativeToOrNull(workingDir.canonicalFile) != null | ||
| return resolvedPath.startsWith(workingDir.canonicalFile) |
Member
There was a problem hiding this comment.
Does the path really need to be within workingDir or would it suffice to check resolvedPath.startsWith(analysisRoot) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the individual commits for details.
Follow up of #11210 (review)