Skip to content

fix(deps): pull brace-expansion past GHSA-rgw5-rvv9-x895 - #2968

Merged
oscharko merged 2 commits into
devfrom
fix/osv-brace-expansion
Aug 3, 2026
Merged

fix(deps): pull brace-expansion past GHSA-rgw5-rvv9-x895#2968
oscharko merged 2 commits into
devfrom
fix/osv-brace-expansion

Conversation

@oscharko

@oscharko oscharko commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

GHSA-rgw5-rvv9-x895 (brace-expansion, CVSS 7.5, dev group) published after the last green scan on dev and now fails the OSV step of workflow hygiene on every pull request — #2967's docs-only diff was the first to trip it. Both affected lines have patched releases, so this bumps the lockfile (1.1.16 → 1.1.18, 5.0.8 → 5.0.9, one npm update brace-expansion) rather than adding a second id-bound waiver beside the #2700 entry — a fix version existing makes a waiver strictly worse.

Verification: the lock now resolves brace-expansion to 1.1.18 and 5.0.9 only (the vulnerable pins are gone); npm run gates:sonar PASS on the diff. Lockfile-only — no manifest ranges changed, no runtime dependency touched. After this merges, the red workflow hygiene runs on open PRs need a rerun to pick up the fixed merge ref.

🤖 Generated with Claude Code

The advisory published after the last green scan and fails the OSV step
of workflow hygiene on every pull request, docs-only ones included.
Patched releases exist on both affected lines (1.1.16 -> 1.1.18,
5.0.8 -> 5.0.9), so the lockfile moves instead of adding a second
id-bound waiver next to the #2700 one.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@oscharko
oscharko temporarily deployed to keiko-for-quality August 3, 2026 17:01 — with GitHub Actions Inactive
@keiko-for-quality

keiko-for-quality Bot commented Aug 3, 2026

Copy link
Copy Markdown

Keiko for Quality — run summary

✅ complete · head 510b07b · 2026-08-03T17:55:37Z · engine v1.8.4 · action ec48db94d70d9a07d729d814ea405157652530be

Metric Count
Total paths 2
Reviewable 2
Excluded 0
Mechanically clean 0
Replayed from cache 0
Freshly reviewed 2
Findings published 0
Suppressed (exact duplicate) 0
Suppressed (similar) 0
Suppressed (dispositioned) 0

Budget: 108368 tokens allotted

@oscharko
oscharko temporarily deployed to keiko-for-quality August 3, 2026 17:04 — with GitHub Actions Inactive
@socket-security

socket-security Bot commented Aug 3, 2026

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn Medium
Recently published: npm brace-expansion published 4 days ago

Location: Package overview

From: package-lock.jsonnpm/@stryker-mutator/core@9.6.1npm/typescript-eslint@8.64.0npm/eslint-plugin-sonarjs@4.2.0npm/brace-expansion@5.0.9

ℹ Read more on: This package | This alert | What are recently published artifacts?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should either be allowlisted to allow recently-published versions, or an older version should be used instead.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/brace-expansion@5.0.9. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@oscharko
oscharko enabled auto-merge (squash) August 3, 2026 17:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 99eb34c60f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package-lock.json
@oscharko
oscharko disabled auto-merge August 3, 2026 17:55
The GHSA-mh99-v99m-4gvg entry recorded 'drop this entry as soon as
brace-expansion ships a patched 1.x' — 1.1.18 is now in the lockfile,
so the id-wide suppression would only hide a reintroduced vulnerable
release from the one gate positioned to catch it. The triage record
keeps the removal rationale.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@oscharko
oscharko temporarily deployed to keiko-for-quality August 3, 2026 17:55 — with GitHub Actions Inactive
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 32b49955-9b79-474d-bcde-8c4ba37ce22c

📥 Commits

Reviewing files that changed from the base of the PR and between eb68af9 and 510b07b.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • osv-scanner.toml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (17)
  • GitHub Check: Cross-platform smoke (macos-latest)
  • GitHub Check: Cross-platform smoke (ubuntu-latest)
  • GitHub Check: Cross-platform smoke (windows-latest)
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (csharp)
  • GitHub Check: review
  • GitHub Check: ui
  • GitHub Check: Coverage suite (keiko-ui)
  • GitHub Check: Coverage shard (packages 2/3)
  • GitHub Check: Build, scan, SBOM, smoke
  • GitHub Check: Core quality
  • GitHub Check: Coverage suite (scripts)
  • GitHub Check: Coverage shard (packages 1/3)
  • GitHub Check: Coverage shard (packages 3/3)
  • GitHub Check: Semantic duplication
  • GitHub Check: Analyze (actions)
  • GitHub Check: Analyze (javascript-typescript)

📝 Walkthrough

Walkthrough

The OSV-Scanner configuration removes the GHSA-mh99-v99m-4gvg suppression and documents that patched releases are present.

Changes

Vulnerability waiver configuration

Layer / File(s) Summary
Remove obsolete suppression
osv-scanner.toml
The time-limited vulnerability waiver was removed. Comments now state that the ignore list is empty and explain the patched dependency releases and lockfile updates.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested labels: 🕐 40+ Minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 2

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the dependency fix but omits most required template sections, including scope, delivery, impact, closure, and risk details. Complete the required description sections and provide the linked issue, scope, verification evidence, impact classification, and risk notes.
Linked Issues check ⚠️ Warning The description links to pull requests but does not provide the required Refs issue reference or a clearly linked tracking issue. Add the applicable issue reference using the required Refs format and link the pull request to that issue.
✅ Passed checks (2 passed)
Check name Status Explanation
Out of Scope Changes check ✅ Passed The changes are limited to the dependency lockfile and obsolete vulnerability-waiver configuration described in the objectives.
Title check ✅ Passed The title uses a conventional format, an imperative subject, and identifies the brace-expansion security update.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oscharko
oscharko temporarily deployed to keiko-for-quality August 3, 2026 17:58 — with GitHub Actions Inactive
@oscharko
oscharko enabled auto-merge (squash) August 3, 2026 17:58
@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

@oscharko
oscharko merged commit de6aa9f into dev Aug 3, 2026
29 checks passed
@oscharko
oscharko deleted the fix/osv-brace-expansion branch August 3, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant