disk: remove local PartitioningMode type #1747
Conversation
achilleas-k
force-pushed
the
rm/partitioning-mode
branch
from
8598a2b to
274a89d
Compare
thozza
left a comment
thozza
left a comment
There was a problem hiding this comment.
A bit more context / motivation / reasoning behind moving the partitioning mode to blueprint repo would be nice, since I'm not fully aware of it (and thus it feels a bit weird TBH).
Other than that, there is a go mod replace in the PR.
go.mod
Outdated
| google.golang.org/protobuf v1.36.6 // indirect | ||
| ) | ||
|
|
||
| replace github.com/osbuild/blueprint => github.com/achilleas-k/blueprint v0.0.0-20250812104104-18df7eb83d6a |
Remove the partition.PartitioningMode type and import it from osbuild/blueprint. The partitioning mode is a blueprint option that can be used in conjunction with Filesystem customizations to control how the partition table will change to accommodate the new partitions (by default, a partition table will be "upgraded" to LVM when a custom filesystem is added, unless the partitioning mode is set to "raw"). Initially, it was defined as an image option, and is still treated as an image option here, while being a Blueprint option in all user-facing places (osbuild-composer). This commit does not remove it from the image options, but drops the images copy of the enum type to use the blueprint.PartitioningMode instead.
Started writing a longer commit message that explains the whole thing and I think we might have a bug that ignores the mode here. I'll add some tests. Setting this to draft in the meantime. |
achilleas-k
force-pushed
the
rm/partitioning-mode
branch
from
274a89d to
4c79b25
Compare
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
2 participants
Remove the partition.PartitioningMode type and import it from osbuild/blueprint.
This is the other side of osbuild/blueprint#28