bib: remove bootc-image-builder binary and build from ibcli #1157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2025
mvo5
force-pushed
the
use-ibcli
branch
4 times, most recently
from
26384e1 to
1118516
Compare
mvo5
force-pushed
the
use-ibcli
branch
2 times, most recently
from
b19dbb2 to
00c72f1
Compare
mvo5
requested review from
croissanne and
thozza
and removed request for
a team
achilleas-k
reviewed
Dec 8, 2025
achilleas-k
reviewed
Dec 8, 2025
build.sh
Outdated
| # XXX2: remove bootc-image-buidler build here entirely and take it from the upstream | ||
| # image-builer-cli container in the containerfile instead? | ||
| # | ||
| # XXX: replace with git clone --depth 1 github.com/osbuild/image-builder-cli@rev |
Member
There was a problem hiding this comment.
Isn't it possible to do this already?
Collaborator
Author
There was a problem hiding this comment.
Oh boy, sorry for that too. I went over this again and I hope I did not miss another silly leftover.
mvo5
force-pushed
the
use-ibcli
branch
3 times, most recently
from
c2a182c to
d7ae12b
Compare
achilleas-k
force-pushed
the
use-ibcli
branch
from
517a84f to
53bb960
Compare
achilleas-k
previously approved these changes
Dec 9, 2025
This commit removes bib/cmd/bootc-image-builder and all pieces that it pulled in and replaces it with the new image-builder-cli multicall binary.
This test is no longer working, it seems its a result of the merge of osbuild/image-builder-cli#316 Drop it for now so that we can move forward with the merge. There is a similar test in https://github.com/osbuild/image-builder-cli/pull/316/files#diff-57c49abc8a31b46856c2eecb2edfeff6072cd8d0edf769a67b6d4fdaabd8321aR100 that does not cover "auto" but any fixes/regression should be done in the ibcli repo.
ondrejbudai
reviewed
Dec 12, 2025
Member
ondrejbudai
left a comment
ondrejbudai
left a comment
There was a problem hiding this comment.
Let's try to get rid of most of the go.mod before merging it. Tbh, I wonder if we should also try to get rid if the canary thing so we can actually remove ALL go code from this repo.
This commit removes the upload command. It is still available in the ibcli git repo [0] but given that its not actually part of the bootc-image-builder container I wonder if we could simply remove it everywhere? [0] osbuild/image-builder-cli#396
Collaborator
Author
|
There is a faiure in the centos-10 tests ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes bib/cmd/bootc-image-builder and all pieces that it pulled in and replaces it with the new image-builder-cli multicall binary.
It also removes one test which is a bit unfortunate but with the move to ibcli this needs to be re-added there anyway.