Repository navigation
[ruby] Preserve source data and inherited plural output - #35
Merged
Merged
Conversation
Give copied definitions independent mutable maps so generated fallbacks do not change their sources or depend on definition order. Resolve plural forms through references, preserving explicit singular overrides and Gettext developer text. Compute fallbacks once per language, support script and three-letter locale fallbacks, and reject invalid reference graphs before inherited lookups. Keep empty plural output skippable. Cover ownership, output types, fallback order, and reference validation. Signed-off-by: Alexander Borsuk <me@alex.bio>
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generating a regional locale mutates the parsed definitions, so an alias can change from
Pedestrian BridgetoBridgewhen its reference appears first. Plural aliases also lose their forms, and Gettext export can crash when developer text is inherited.Based directly on
organicmaps; contains only Ruby changes. Related review: #33. This PR can be reviewed independently of #33.Validation:
Implementation and validation assisted by Codex.