Stop audio after candidate submission - #593
Merged
kauereinbold merged 2 commits intoAug 13, 2026
Merged
Conversation
kauereinbold
self-requested a review
August 13, 2026 13:00
Collaborator
|
This is a first contribution from someone new to the project, and we haven't set how we handle reviews for contributors who haven't been involved before. @dthaler, can we discuss how you want to handle first-time contributions before this one gets approved? I'm testing the change locally in the meantime and will post findings separately. |
Collaborator
First-time contributions are welcomed and gratefully accepted. |
kauereinbold
approved these changes
Aug 13, 2026
kauereinbold
left a comment
Collaborator
There was a problem hiding this comment.
Tested locally and it is working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #592.
Validation
dotnet restore -r win-x86dotnet build --no-restore -c Release -r win-x86(0 errors; existing net6/toolchain warnings remain)dotnet test --no-restore -r win-x86(completed successfully; the solution has no test projects)dotnet publish --no-restore -c Release -r win-x86 -o /tmp/orcahello-592-publishorigin/mainfails the required successful-update → player-teardown → list-reload sequence; this patch passes itAI assistance
Codex (GPT-5) identified the missing lifecycle call, applied the one-line patch, and ran the validation above.