Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
During Kubernetes node churn, backend entries for removed nodes can remain on an OCI load balancer. A backend-set update that adds replacement nodes before removing those stale entries can exceed the load balancer's total backend limit (
backends-per-lb-limit) and fail, leaving backend sets out of sync.Summary
Validation
go test -mod=vendor ./pkg/...Operational note
A failed OCI delete or update returns an error for normal reconciliation retry. The change does not remove a backend that is still in the desired set.
Also note, these proposed changes have been running in our production clusters for a number of weeks.