Refactor wls discovery script to align with WDT discover.py and remove Internal WDT dependencies #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
telake
reviewed
Dec 3, 2025
telake
approved these changes
Dec 3, 2025
Member
telake
left a comment
telake
left a comment
There was a problem hiding this comment.
I am approving based on what I saw in the code and in the listed testing that was done, but I am concerned about the regex locating the environment variable value. Although approved, can you please make sure that the environment variables, as they are defined in the on-prem.env file will always be captured by the regex?
Contributor
Author
Removed export from regex: #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.oraclecorp.com/jira/browse/JCS-15069
Tested with JRF, Non-JRF and Secure mode domains with multiple nodes.