fishing to see if testing explicitly for success will work for matrixed tests with fail-fast:false

[grokspawn]

Description of the change:
Test matrixed e2e test job for non-success, instead of explicitly for failure.

Motivation for the change:
We're seeing cases where PRs are merging even though the matrixed aggregate workflow 'e2e' has not completed. Reading up on some docs, it appears that there are other potential 'failure but not "failure"' modes that can occur with fail-fast:true set.

Architectural changes:

Testing remarks:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Bug fixes are accompanied by regression test(s)
• e2e tests and flake fixes are accompanied evidence of flake testing, e.g. executing the test 100(0) times
• tech debt/todo is accompanied by issue link(s) in comments in the surrounding code
• Tests are comprehensible, e.g. Ginkgo DSL is being used appropriately
• Docs updated or added to /doc
• Commit messages sensible and descriptive
• Tests marked as [FLAKE] are truly flaky and have an issue
• Code is properly formatted

[grokspawn]

/approve

[oceanc80]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, oceanc80

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [grokspawn,oceanc80]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oceanc80]

/lgtm