correct deprecation example indentation#339
Merged
grokspawn merged 1 commit intooperator-framework:masterfrom Jun 2, 2025
Merged
correct deprecation example indentation#339grokspawn merged 1 commit intooperator-framework:masterfrom
grokspawn merged 1 commit intooperator-framework:masterfrom
Conversation
joelanford
reviewed
Jun 2, 2025
Comment on lines
332
to
344
| schema: olm.bundle | ||
| name: deprecation-example-operator.v1.68.0 | ||
| message: | | ||
| deprecation-example-operator.v1.68.0 is deprecated. Uninstall and install deprecation-example-operator.v1.72.0 for support. | ||
| - reference: | ||
| schema: olm.package | ||
| schema: olm.package | ||
| message: | | ||
| package deprecation-example is end of life. Please use 'non-deprecated-example' package for support. | ||
| - reference: | ||
| schema: olm.channel | ||
| name: alpha | ||
| schema: olm.channel | ||
| name: alpha | ||
| message: | | ||
| channel alpha is no longer supported. Please switch to channel 'stable'. |
Member
There was a problem hiding this comment.
I see combo of spaces and tabs, which I'm guessing is the underlying issue. Maybe remove all the tabs?
Contributor
Author
There was a problem hiding this comment.
Not related, but still preferred to remove. This looks like another instance of "sometimes copy/paste from google doc loses nesting".
And then an immediate re-push as I realize I borked the message nesting by untabifying. 😅
grokspawn
force-pushed
the
deprecation-indentation
branch
2 times, most recently
from
289921e to
4c25f02
Compare
Contributor
Author
|
lint is consistently failing in CI due to the number of links it attempts to validate. I've verified that the links resolve, and I've been able to pass the tests locally without issue, but as the CI claims, a large number of links can experience failure. Separately, perhaps it's time to deprecate legacy. |
Signed-off-by: grokspawn <jordan@nimblewidget.com>
grokspawn
force-pushed
the
deprecation-indentation
branch
from
4c25f02 to
7a685ec
Compare
joelanford
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.