Open
Conversation
If the build request contains a device profile that is not contained in the imagebuilder's device list, the build crashes with an internal server error. This happens when the DTS for the device is incorrect, see link for example. Fix by checking before attempting to extract data from the imagebuilder output. Link: openwrt#1583 Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1584 +/- ##
===========================================
+ Coverage 80.75% 91.56% +10.80%
===========================================
Files 15 16 +1
Lines 977 1743 +766
===========================================
+ Hits 789 1596 +807
+ Misses 188 147 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
This happens when the requested dts compatible/profile is valid in the profiles.json but it does not match any profile in imagebuilder. i.e. When overwriting DEVICE_NAME and it does not match the image profile name (original DEVICE_NAME) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the build request contains a device profile that is not contained in the imagebuilder's device list, the build crashes with an internal server error. This happens when the DTS for the device is incorrect, see link for example.
Fix by checking before attempting to extract data from the imagebuilder output.
Link: #1583