Skip to content

build: check profile name before usage#1584

Open
efahl wants to merge 1 commit intoopenwrt:mainfrom
efahl:profile-check
Open

build: check profile name before usage#1584
efahl wants to merge 1 commit intoopenwrt:mainfrom
efahl:profile-check

Conversation

@efahl
Copy link
Contributor

@efahl efahl commented Mar 6, 2026

If the build request contains a device profile that is not contained in the imagebuilder's device list, the build crashes with an internal server error. This happens when the DTS for the device is incorrect, see link for example.

Fix by checking before attempting to extract data from the imagebuilder output.

Link: #1583

If the build request contains a device profile that is not contained
in the imagebuilder's device list, the build crashes with an
internal server error.  This happens when the DTS for the device
is incorrect, see link for example.

Fix by checking before attempting to extract data from the
imagebuilder output.

Link: openwrt#1583
Signed-off-by: Eric Fahlgren <ericfahlgren@gmail.com>
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.56%. Comparing base (5e65dec) to head (633899d).
⚠️ Report is 348 commits behind head on main.

Files with missing lines Patch % Lines
asu/build.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1584       +/-   ##
===========================================
+ Coverage   80.75%   91.56%   +10.80%     
===========================================
  Files          15       16        +1     
  Lines         977     1743      +766     
===========================================
+ Hits          789     1596      +807     
+ Misses        188      147       -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@map-b
Copy link
Contributor

map-b commented Mar 6, 2026

This happens when the DTS for the device is incorrect, see link for example.

This happens when the requested dts compatible/profile is valid in the profiles.json but it does not match any profile in imagebuilder. i.e. When overwriting DEVICE_NAME and it does not match the image profile name (original DEVICE_NAME) ten64-mtd vs traverse_ten64_mtd, solved using BOARD_NAME which does not affect the generated profiles.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants