Fix importing of JITAR sets. #2898
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The settings `att_to_open_children` and `counts_parent_grade` were not being transferred from the set definition file due to incorrect casing used. Thanks to @hal4stvf for pointing this out. Part of the problem here is the mix of snake case and cammel case. The set definition file, the problem table in the database, and the default value from `defaults.config` use `att_to_open_children`. However, the `addProblemToSet` method expects the argument of `attToOpenChildren`. We need to eliminate snake case usage altogether. It is the most annoying case to type (`shift _ t` takes three keystrokes but `shift t` only takes two). But even worse is mixing these different casing schemes, particularly as is done in this case. This fixes issue openwebwork#2897.
drgrice1
force-pushed
the
bugfix/jitar-set-import
branch
from
8e5e53f to
2e2b584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The settings
att_to_open_childrenandcounts_parent_gradewere not being transferred from the set definition file due to incorrect casing used. Thanks to @hal4stvf for pointing this out.Part of the problem here is the mix of snake case and cammel case. The set definition file, the problem table in the database, and the default value from
defaults.configuseatt_to_open_children. However, theaddProblemToSetmethod expects the argument ofattToOpenChildren. We need to eliminate snake case usage altogether. It is the most annoying case to type (shift _ ttakes three keystrokes butshift tonly takes two). But even worse is mixing these different casing schemes, particularly as is done in this case.This fixes issue #2897.