Refactor check_modules script #2893
Conversation
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
I think this is a good idea. However, I think that it may be necessary to have separate packagetype options for Debian and Ubuntu. Usually packages are the same for the two, but not always. Could that be an issue for Red Hat and Oracle?
bin/check_modules.pl
Outdated
| my %modulesList = ( | ||
| 'Archive::Tar' => { | ||
| 'package' => { | ||
| 'deb' => 'perl-modules', |
There was a problem hiding this comment.
Change this to
| 'deb' => 'perl-modules', | |
| 'deb' => 'perl', |
There is no perl-modules package (at least for Ubuntu). There is a perl-modules-5.38 package on Ubuntu 24 which contains all of the packages you listed for the perl-modules pakcage. However it would probably be a bad idea to list that here. That would be specific to the version of Ubuntu. The perl package would be on all versions of Ubuntu, and it depends on the perl-modules-5.38 package (that would be a different Perl version for other Ubuntu versions though), and so it will be installed if the perl package is.
bin/check_modules.pl
Outdated
| }, | ||
| 'Data::Dumper' => { | ||
| 'package' => { | ||
| 'deb' => 'libperl', |
There was a problem hiding this comment.
Change this to
| 'deb' => 'libperl', | |
| 'deb' => 'perl', |
There is also no libperl package, but there is libperl5.38t64. The perl package also depends on that.
|
How hard would it be to detect the platform of the system? Seems like there is info in Perhaps if the |
I changed from package manager to distribution so that this is currently specific to Ubuntu and RHEL. I checked Oracle, and it uses the same perl package names as RHEL, but it could be different for other distros. |
bin/check_modules.pl
Outdated
| using the apt package manager | ||
| 'rhel' - for RedHat Enterprise Linux and equivalents with the | ||
| EPEL and CodeReady Builder repositories enabled | ||
| (e.g. Rocky Linux, Oracle Linux) |
There was a problem hiding this comment.
I just noticed this. Fix the indentation here. There are tabs characters that are messing with things.
|
Would it be possible to add |
I don't like this. It would be based on the assumption that if there isn't a Debian package specified, then the name would match the ubuntu package, but it's possible that there isn't a Debian package at all. |
|
In practice I highly doubt that will happen, ubuntu gets its packages from debian (really the alias should go the other way). Would having the option |
4 participants
Update the the
check_modules.plscript to add the name of the Debian and RedHat package for perl packages where available.This adds another flag when calling the script, where the user can specify if they are on a deb- or rpm-based system, and the output will suggest a command for installing any missing packages.