Skip to content

fix: catch all exceptions during Zigbee device enrichment #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CFenner merged 2 commits into from
Apr 28, 2026
Merged

fix: catch all exceptions during Zigbee device enrichment #751

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0c5bfa
fix: catch all exceptions during Zigbee device enrichment
lackas Apr 28, 2026
2396b0a
fix: suppress pylint broad-exception-caught for enrichment
lackas Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PyViCare/PyViCare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
from PyViCare.PyViCareOAuthManager import ViCareOAuthManager
from PyViCare.PyViCareRoomControl import RoomControl
from PyViCare.PyViCareService import ViCareDeviceAccessor, ViCareService
from PyViCare.PyViCareUtils import PyViCareInvalidDataError, PyViCareNotSupportedFeatureError
from PyViCare.PyViCareUtils import PyViCareInvalidDataError

logger = logging.getLogger(__name__)
logger.addHandler(logging.NullHandler())
Expand Down Expand Up @@ -86,7 +86,7 @@ def __enrichZigbeeDevices(self):
room_control = RoomControl(device_config.service)
try:
actor_map = room_control.buildActorRoomMap()
except (KeyError, IndexError, PyViCareNotSupportedFeatureError):
except Exception: # pylint: disable=broad-exception-caught
logger.debug("Could not build actor map for %s", device_config.getModel(), exc_info=True)
continue

Expand Down
Loading