Use ISSUES_PAT for unanswered issues workflow and fail hard on token misconfiguration#523
Open
Use ISSUES_PAT for unanswered issues workflow and fail hard on token misconfiguration#523
Conversation
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com> Made-with: Cursor
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Signed-off-by: Mark Harris <mharris@nvidia.com>
Contributor
|
I'm concerned that this is the wrong way to draw attention to these issues. It will be like when a build system spits out a thousand lines of warnings and you just train yourself to ignore them because you can't possibly process all that information. The same will necessarily happen here - there's no way we can consume this information in "notification" form. I think it should, if it is going to be daily or regularly, simply say, "there are N P0 issues, M P1, issues, ... P5 issues, Q unranked issues, with a link to the issues and nothing else. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follows up on #522 which fixed insider filtering in the script.
ISSUES_PATinstead ofGITHUB_TOKEN: The defaultGITHUB_TOKENcannot resolve org/team membership, soauthor_associationis unreliable in CI. The workflow now uses the
ISSUES_PATsecret (afine-grained PAT with
Organization > Members > Read).fetch_team_membersnowraises instead of silently falling back to
author_associationwhen theteam members API call fails. This prevents sending an incorrect report.
Test plan
issues (8 fvdb-core + 5 fvdb-reality-capture), no insiders, no duplicates