Open
Conversation
github-actions
bot
added
documentation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds a new Chinese documentation page Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/advanced-features/auth-plugin.md`:
- Around line 66-77: The whiteList and notAuthList arrays are inconsistent:
whiteList entries use leading slashes while notAuthList entries do not, which is
confusing; fix this by standardizing the pattern so both arrays use absolute
paths (prepend '/' to every entry in notAuthList) or alternatively normalize the
request path before matching (e.g., ensure path starts with '/' once) so the
.includes() checks behave consistently; update the arrays named whiteList and
notAuthList and the matching logic that uses .includes() accordingly.
🧹 Nitpick comments (2)
docs/advanced-features/auth-plugin.md (2)
85-85: Special characters rendering may be affected by Markdown escaping.The backslash-escaped characters (
\*,\_,\|) are Markdown escape sequences. In rendered output, they should display correctly, but the raw text looks cluttered. Consider wrapping the special characters in an inline code span to make it clearer:Proposed fix
-- 必须包含特殊字符：!@#$%^&\*()\_+-=[]{};":\|,.'<>?。 +- 必须包含特殊字符：`!@#$%^&*()_+-=[]{};":|,.'<>?`
101-106: Document ends abruptly without a concluding newline or closing section.Line 106 ends mid-sentence without a trailing newline, which is a minor Markdown hygiene issue. Most linters and editors expect a final newline character at the end of a file.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/advanced-features/auth-plugin.md`:
- Around line 9-28: Replace all invalid closing br tags `</br>` in the
auth-plugin.md document with a proper self-closing `<br>` or use blank lines for
paragraph breaks; search for every occurrence of the literal `</br>` in the file
(including the header and all list/feature sections) and update them so Markdown
engines render line breaks consistently while preserving surrounding text and
image links.
🧹 Nitpick comments (1)
docs/advanced-features/auth-plugin.md (1)
66-77: Whitelist snippet should use a copy‑paste‑ready array format.
Consider wrapping these entries in a JavaScript array with commas to reduce ambiguity for readers.📌 Suggested doc tweak
- // 登录相关接口 - '/platform-center/api/user/login' - '/platform-center/api/user/register' - '/platform-center/api/user/forgot-password' - '/platform-center/api/user/me' - '/platform-center/api/user/tenant' - // AI 相关接口 - 'app-center/api/chat/completions' - 'app-center/api/ai/chat' - 'app-center/api/ai/search' + const whiteList = [ + // 登录相关接口 + '/platform-center/api/user/login', + '/platform-center/api/user/register', + '/platform-center/api/user/forgot-password', + '/platform-center/api/user/me', + '/platform-center/api/user/tenant', + // AI 相关接口 + 'app-center/api/chat/completions', + 'app-center/api/ai/chat', + 'app-center/api/ai/search', + ]
github-actions
bot
added
the
release
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@docs/advanced-features/auth-plugin.md`:
- Around line 42-49: Update the docs listing for the login component structure
to reflect that useLogin.ts lives in the js subdirectory: change the entry for
useLogin.ts to indicate its full path
packages/design-core/src/login/js/useLogin.ts (or note “useLogin.ts (in
login/js/)”) while leaving the other component names Index.vue, Login.vue,
Register.vue, ForgotPassword.vue, and RegisterSuccess.vue as-is so readers can
find useLogin.ts under the login/js folder.
- Around line 78-87: The doc and implementation disagree on allowed special
characters; reconcile them by either adding the missing characters to the
validator or updating the docs to match the validator. Locate the
special-character set in the login validator (the string/regex variable in
useLogin.ts, e.g. specialChars or the regex on line ~3) and add the missing "{"
and "]" if you want to match the docs, or update the markdown list in
auth-plugin.md to the exact characters currently used by the validator; ensure
both the docs and the validator contain the identical character sequence.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/advanced-features/auth-plugin.md`:
- Around line 66-77: The code block shows URL entries but is not valid
JavaScript; change it to a real array by replacing the block with a proper
JavaScript array declaration such as const whiteList = [ /* entries */ ] adding
commas between items and preserving comments, closing the array and code fence,
or alternatively label the block as a pseudo-list/plain text if you
intentionally don't want runnable JS; reference the whiteList identifier when
making the change.
hexqi
reviewed
Feb 12, 2026
|
|
||
| - 位置：packages/design-core/src/login/ | ||
| - 组件结构：</br> | ||
| 1. Index.vue：登录页面容器</br> |
hexqi
reviewed
Feb 12, 2026
| - 组件结构：</br> | ||
| 1. Index.vue：登录页面容器</br> | ||
| 2. Login.vue：登录表单</br> | ||
| 3. Register.vue：注册表单</br> |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@docs/advanced-features/auth-plugin.md`:
- Around line 35-40: The snippet declares abortControllers and an incomplete
abortAllRequests, so either complete the function or mark it as illustrative;
implement abortAllRequests(message = '用户未登录，请求已取消') to iterate over
abortControllers, call abort() on each controller, clear the Map and optionally
log or dispatch the provided message, or replace the incomplete line with a
short comment like "// simplified excerpt — full implementation in source" to
clarify it's not full code; reference abortControllers and abortAllRequests when
making the change.
Comment on lines
+35
to
+40
| ```javascript | ||
| // 使用 Map 存储所有请求的 AbortController | ||
| const abortControllers = new Map() | ||
| // 支持取消所有进行中的请求 | ||
| const abortAllRequests = (message = '用户未登录，请求已取消') | ||
| ``` |
Contributor
There was a problem hiding this comment.
Complete the code example or clarify it's a snippet.
The JavaScript example shows variable declarations but the abortAllRequests function declaration is incomplete (no function body or parameters shown). Consider either showing the complete implementation or adding a comment indicating this is a simplified excerpt.
📝 Suggested clarification
4. 并发请求管理
```javascript
// 使用 Map 存储所有请求的 AbortController
const abortControllers = new Map()
- // 支持取消所有进行中的请求
- const abortAllRequests = (message = '用户未登录，请求已取消')
+ // 支持取消所有进行中的请求
+ const abortAllRequests = (message = '用户未登录，请求已取消') => {
+ // ... 具体实现见源码
+ }
```Or alternatively, add a note that this is a conceptual overview:
4. 并发请求管理
+
+ 系统使用以下机制管理并发请求（简化示例）：
+
```javascript
// 使用 Map 存储所有请求的 AbortController
const abortControllers = new Map()
// 支持取消所有进行中的请求
const abortAllRequests = (message = '用户未登录，请求已取消')
```🤖 Prompt for AI Agents
In `@docs/advanced-features/auth-plugin.md` around lines 35 - 40, The snippet
declares abortControllers and an incomplete abortAllRequests, so either complete
the function or mark it as illustrative; implement abortAllRequests(message =
'用户未登录，请求已取消') to iterate over abortControllers, call abort() on each
controller, clear the Map and optionally log or dispatch the provided message,
or replace the incomplete line with a short comment like "// simplified excerpt
— full implementation in source" to clarify it's not full code; reference
abortControllers and abortAllRequests when making the change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit