disk.md disk.xp8 fixes, add provisioned state detection for fs.host#1008
Open
cvaroqui wants to merge 9 commits intoopensvc:mainfrom
Open
disk.md disk.xp8 fixes, add provisioned state detection for fs.host#1008cvaroqui wants to merge 9 commits intoopensvc:mainfrom
cvaroqui wants to merge 9 commits intoopensvc:mainfrom
Conversation
The "at least 1 device must be set in the 'devs' provisioning" error is emited by a util/md pkg that should have no knowledge of keywords anyway.
Some fs in the util/filesystems already have a DevicesFormatted func that can serve as a Provisioned() test. Stop merging unknown and undef states in the provisioned state renderer. Use '?' for undef and '!' for unknown.
Add more state helpers: IsSplit() IsPaired(). Use them in the Start() and Abort() state switchs to handle mixed states correctly.
A resource always has the "provisioned" struct, no need to test a "no provisioned data" scenario.
cvaroqui
force-pushed
the
main
branch
2 times, most recently
from
a6a0c69 to
5b9c70e
Compare
* Split the MDDriverProvisioner interface into MDDriverProvisioner and MDDriverUnprovisioner * Change the label format so the md name is always shown and uuid is shown additionnally when available. * Allow wiping from the md name detection too. Previously if the uuid was no longer known we failed to detect the md legs to wipe.
Say "md %s already exists" instead of "md %s is already created" as the test is a pure existance test... it does not validate creation parameters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.