Merged
Conversation
Add a datarecv func to manage backward compat.
* don't use the uuid-base devpath, not supported by mdadm --re-add * use the realpath of the devpath in the --re-add command * log the "succeed" re-add stderr message at the info level instead of error.
And the `POST /api/node/name/<nodename>/action/scsi/scan` handler
$ om node scsi scan -h
Scan the scsi hosts in search of new disks.
This command scans SCSI hosts for new block devices. You can specify specific HBA, target, and LUN to scan.
Usage:
om node scsi scan [flags]
Aliases:
scan, sca, sc
Flags:
--hba string Specify a hba to scan for new block devices. Example: 5001438002432430 or iqn.1993-08.org.debian:01:659b4bbd68bd.
--lun string Specify a logical unit number to scan for new block devices. Example: 1.
--node string submit the action to the selected nodes
--target string Specify a target to scan for new block devices. Example: 5000097358185088 or iqn.clementine.tgt1.
...
Keep the backward compatible command, hidden. Also implement the "ox node scsi prkey".
And flag command groups as "subsystem".
* "schedul", "schedu", "sched", "sche", "sch", "sc" => "sched" * drop all "scsi scan" aliases * drop all "cap scan" aliases
New command, no aliases, autocompletion works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.