[OSPRH-26273] Update observability-operator#844
[OSPRH-26273] Update observability-operator#844openshift-merge-bot[bot] merged 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
Update OBO to v1.0.0 (newer versions would require updates to k8s.io/* as well). This will enable us to use the newest CRD fields easily from telemetry-operator. Mainly the NodeSelector and the TLS related fields.
vyzigold
force-pushed
the
update_obo_100
branch
from
5bfe045 to
54e1bf7
Compare
|
pre-commit failing with CRD check. Comment for each group of failures: The whole The whole The whole Not sure what's up with the proxyConnectHeader. It's a Those errors are from a CRD we import from COO (we don't have much control over it) and they don't seem like breaking issues to me (either a required field enveloped inside an optional struct or a missing list tag). I think we should be able to waive the test. |
|
is this planned for fr5? if not, we should wait to land it until we branched to not introduce the crd change. the plan is to branch today. |
|
@stuggi It's a prerequisite for supporting NodeSeletor for Prometheus, which IMO isn't that important to attempt getting it into FR5 right now. But it's reported as a bug with a customer impact, so this and a followup PR would be cherry-picked onto the stable branch some time after FR5 releases, so that the changes get into the next bugfix release. |
thanks for clarification. yes would be good if we can backport it. either right after branching or later |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4debffc13b5a45ca92d2ffb9040308ed ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 14s |
|
recheck |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/7f7fbf65a68443a7843a7791911fd7bd ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 59s |
|
recheck |
|
@stuggi the branches were created, so we should be good now right? |
|
I agree, the new NoNewRequiredFields can be ignored as the upper element is optional
Its not super critical and since iiuc this is coming from an import we could probably ignore it for now. I think there is one annotation missing for the additionalProperties array, like |
yes, we are good to land it on main now |
|
/override ci/prow/precommit-check |
|
@vyzigold: Overrode contexts on behalf of vyzigold: ci/prow/precommit-check DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlarriba, vyzigold The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit 39a4be8
into
openstack-k8s-operators:main
|
/cherry-pick 18.0-fr5 |
|
@vyzigold: #844 failed to apply on top of branch "18.0-fr5": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Update OBO to v1.0.0 (newer versions would require updates to k8s.io/* as well). This will enable us to use the newest CRD fields easily from telemetry-operator. Mainly the NodeSelector and the TLS related fields.