NO-JIRA: Fix the All panel in the RegressedTestsModal

[smg247]

Due to #3236, the All panel was passing an object containing a single array keyed by the view name instead of a direct array as expected.

Summary by CodeRabbit

• Bug Fixes
  • Fixed the All tab in the Regressed Tests modal so it now respects the selected view. The tab correctly filters and shows view-specific regressed tests instead of showing all tests regardless of the current view selection.

[openshift-ci-robot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@smg247: This pull request explicitly references no jira issue.

Details

In response to this:

Due to #3236, the All panel was passing an object containing a single array keyed by the view name instead of a direct array as expected.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The RegressedTestsModal component now reads a view value from CompReadyVarsContext (via useContext) and uses it to select regressed tests for the All tab (allRegressedTests?.[view] || []), making the All tab data view-specific.

Changes

Cohort / File(s)	Summary
Context-based View Parametrization sippy-ng/src/component_readiness/RegressedTestsModal.js	Imported CompReadyVarsContext and useContext; consumed view from context; updated All tab data source to `allRegressedTests?.[view]

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly and clearly describes the specific fix being implemented: correcting the data flow in the All panel of RegressedTestsModal to use the proper array format.
Go Error Handling	✅ Passed	The custom check for Go error handling is not applicable to this pull request because the PR only modifies a JavaScript file, not a Go file.
Sql Injection Prevention	✅ Passed	The modified file is a frontend React component containing no SQL operations, database queries, or SQL statement construction, making SQL injection prevention checks inapplicable.
Excessive Css In React Should Use Styles	✅ Passed	The RegressedTestsModal.js file contains one inline style object with exactly 3 simple margin properties, falling within the acceptable 3-4 property threshold. The styles are straightforward spacing values, not complex styling warranting extraction.
Single Responsibility And Clear Naming	✅ Passed	The RegressedTestsModal component maintains single responsibility by focusing on UI presentation with proper context usage for state management, and uses clear, specific naming without generic patterns.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

No actionable comments were generated in the recent review. 🎉

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@sippy-ng/src/component_readiness/RegressedTestsModal.js`:
- Line 134: The code reads allRegressedTests[view] which can throw if
allRegressedTests is undefined; update the RegessedTestsModal component so the
access is guarded with optional chaining on the allRegressedTests prop when
assigning regressedTests (use a safe access that falls back to an empty array),
referencing the allRegressedTests and view symbols and the regressedTests prop
assignment to locate the change.

[neisw]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, smg247

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw,smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling required tests:
/test e2e

[smg247]

/retest

[smg247]

/test e2e

[smg247]

/override ci/prow/e2e
Errors are persistent, but unrelated to this change. I will dig more tomorrow.

[openshift-ci]

@smg247: Overrode contexts on behalf of smg247: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e
Errors are persistent, but unrelated to this change. I will dig more tomorrow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@smg247: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.