[SDCICD-1693] script for parameterized jenkins job to run osde2e KRKN…#3152
[SDCICD-1693] script for parameterized jenkins job to run osde2e KRKN…#3152varunraokadaparthi wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varunraokadaparthi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
varunraokadaparthi
force-pushed
the
SDCICD-1693
branch
2 times, most recently
from
5aa99d6 to
a7073f1
Compare
… AI command - Add `scripts/parameterized-job-krknai.sh`: Jenkins parameterized job script that runs the osde2e krkn-ai command inside a Docker container, forwarding all required credentials (OCM, AWS, GCP) and krkn-ai configuration (namespace, pod label, scenarios, fitness query, health checks, generations, population) as environment variables, then copies junit results for publishing. - Fix stderr capture in `pkg/krknai/krknai.go`: move container stderr logging into a defer block so diagnostic output is always logged, even when container execution fails and cmd.Run() returns early with an error.
varunraokadaparthi
force-pushed
the
SDCICD-1693
branch
from
a7073f1 to
02624f9
Compare
|
@varunraokadaparthi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| -e KRKN_TOP_SCENARIOS_COUNT \ | ||
| -e GEMINI_API_KEY \ | ||
| -e REPORT_DIR="/tmp/${REPORT_DIR}" \ | ||
| quay.io/redhat-services-prod/osde2e-cicada-tenant/osde2e:latest krkn-ai --configs "${CONFIGS}" --skip-destroy-cluster "$( [ "${SKIP_MUST_GATHER}" = "true" ] && echo "--skip-must-gather" )" --log-analysis-enable |
There was a problem hiding this comment.
When SKIP_MUST_GATHER is false, it create an empty "" argument. The script passes nothing, so the default true takes effect — must-gather is still skipped.
minlei98
left a comment
minlei98
left a comment
There was a problem hiding this comment.
It will be helpful to review with Jenkins job template PR
| docker start -a osde2e-krknai-run | ||
|
|
||
| # copy the junit results xml for publishing | ||
| docker cp osde2e-krknai-run:/tmp/osde2e-report . |
There was a problem hiding this comment.
- if the osde2e-krknai-run container exits with a failure code, that exit code is lost. The script's final exit code comes from docker cp. Jenkins will report success even when tests fail. suggest:
docker start -a osde2e-krknai-run
rc=$?
docker cp osde2e-krknai-run:/tmp/osde2e-report .
exit $rc
|
|
||
| docker start -a osde2e-krknai-run | ||
|
|
||
| # copy the junit results xml for publishing |
There was a problem hiding this comment.
copy krkn-ai results instead of Junit results xml
3 participants
… AI command
scripts/parameterized-job-krknai.sh: Jenkins parameterized job script that runs the osde2e krkn-ai command inside a Docker container, forwarding all required credentials (OCM, AWS, GCP) and krkn-ai configuration (namespace, pod label, scenarios, fitness query, health checks, generations, population) as environment variables, then copies junit results for publishing.pkg/krknai/krknai.go: move container stderr logging into a defer block so diagnostic output is always logged, even when container execution fails andcmd.Run()returns early with an error.