Fix Slack channel to use saas configured channel

[YiqinZhang]

Fixes Slack notifications not being sent for ad-hoc test suite failures when LLM log analysis is disabled.

Decouple notification queueing from EnableAnalysis flag — queueNotification is always called on failure
sendFailureNotification uses SLACK_CHANNEL (SaaS parameter) directly for channel resolution
Per-suite and global notifications are mutually exclusive to prevent duplicates

Notification paths

Scenario	Per-suite notification	Global notification
No suites, test failed	None (queue empty)	Sent
Suites configured, test failed, analysis on	Sent (with LLM content)	Skipped
Suites configured, test failed, analysis off	Sent (without LLM content)	Skipped
Provision failed, suites configured	None (tests never ran)	Sent (fallback)
Provision failed, no suites	None	Sent

SDCICD-1758

[openshift-ci-robot]

There are test jobs defined for this repository which are not configured to run automatically. Comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger jobs most likely to be impacted by the proposed changes.Comment /pipeline required to trigger all required & necessary jobs.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8dfab127-7791-4eec-a80a-ea237ac4c466

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure the reviews.tools.languagetool setting to enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YiqinZhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [YiqinZhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[YiqinZhang]

/pipeline required

[openshift-ci-robot]

Scheduling required tests:
/test hypershift-pr-check

[ritmun]

Keeping parity with original logic in this prior to separating slack from log analysis:
Do we need one more conditional here so we skip this for suite level errors?
viper.GetString(config.Tests.TestSuites) == "" && viper.GetString(config.Tests.AdHocTestImages) == ""

[YiqinZhang]

This case is handled in sendDeferredNotifications().

Scenario	Per-suite notification	Global notification
No suites configured, test failed	None (queue empty) → false	Sent
No suites configured, test passed	None → false	Skipped (ExitCode == Success)
Suites configured, tests ran and failed	Sent → true	Skipped (deferredSent=true)
Suites configured, tests ran and passed	Sent → true	Skipped
Provision failed, suites configured	None (tests never ran) → false	Sent (fallback)

[YiqinZhang]

/test hypershift-pr-check

[ritmun]

I think this update is not fixing the issue of suite level slacks not going out.

The pending collection of notifications is staying empty, because it's still dependent on llm enabled flag, and it's set to false. This is why test suite notifications(deferred) aren't going out. Slack should be independent of log analysis per https://issues.redhat.com/browse/SDCICD-1767.

Continuing discussion in slack

[ritmun]

Suggested change

	if viper.GetBool(config.LogAnalysis.EnableAnalysis) {
	runLogAnalysisForAdHocTestImage(ctx, logger, testSuite, combinedErr, exeConfig.OutputDir)
	} else {
	queueNotification(testSuite, "")
	}
	// is this possible?
	additionalContent := ""
	if viper.GetBool(config.LogAnalysis.EnableAnalysis) {
	// get this returned from function
	additionalContent = runLogAnalysisForAdHocTestImage(ctx, logger, testSuite, combinedErr, exeConfig.OutputDir)
	}
	queueNotification(testSuite, additionalContent)

[ritmun]

This approach will work, with one suggestion for more concise flow.

[ritmun]

/override ci/prow/hypershift-pr-check

[openshift-ci]

@ritmun: Overrode contexts on behalf of ritmun: ci/prow/hypershift-pr-check

Details

In response to this:

/override ci/prow/hypershift-pr-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@YiqinZhang: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[ritmun]

/lgtm

[ritmun]

related to SDCICD-1767