Skip to content

[OSDOCS#17598]: Added new module for removing device and device classes for 4.21 #105230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stevsmit merged 2 commits into from
Jan 30, 2026
Merged

[OSDOCS#17598]: Added new module for removing device and device classes for 4.21 #105230

stevsmit merged 2 commits into from
Jan 30, 2026

Conversation

@bjahagir-OpenShift
Copy link
Contributor

@bjahagir-OpenShift bjahagir-OpenShift commented Jan 22, 2026 •
edited by stevsmit
Loading

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 22, 2026
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 22, 2026 •
edited
Loading

🤖 Fri Jan 30 14:07:04 - Prow CI generated the docs preview:

https://105230--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage_local/persistent-storage-using-lvms.html

@bjahagir-OpenShift
Copy link
Contributor Author

bjahagir-OpenShift commented Jan 22, 2026 •
edited
Loading

@qJkee and @mmakwana30 - This is the new PR for addition of new topic Removal of devices and device classes from LVMS. Kindly review.

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 22, 2026
@stevsmit stevsmit added this to the Planned for 4.21 GA milestone Jan 22, 2026
stevsmit
stevsmit reviewed Jan 22, 2026
View reviewed changes
Copy link
Member

@stevsmit stevsmit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks pretty good. Some suggestions. I assume that this is one of your first/early PRs so nice job.

Make sure that the WARNINGS need to be warnings and not IMPORTANT; I'm not sure how this CR works really. Here's the link to the differences:

https://redhat-documentation.github.io/supplementary-style-guide/#admonitions

You could also do something like make "Removing the device paths in the deviceSelector.paths field" a level 2 subheading under "About removing devices and device classes from a volume group". For example:

= About removing devices and device classes from a volume group

== Removing the device paths in the deviceSelector.paths field

== Removing the deviceClass from the LVMCluster

in the same module. It's kind of up to you. Just an idea.

This will need QE ack before I can merge.

@stevsmit stevsmit removed the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 22, 2026
@bjahagir-OpenShift bjahagir-OpenShift force-pushed the bjahagir-OSDOCS-17598 branch 3 times, most recently from a5094b1 to 9690d57 Compare January 27, 2026 17:14
@mmakwana30
Copy link

mmakwana30 commented Jan 28, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026
@bjahagir-OpenShift
Copy link
Contributor Author

bjahagir-OpenShift commented Jan 28, 2026

@stevsmit - both Dev and QA reviewed the content and added /lgtm tag. When we are merging 4.21 content, we can merge this PR as well.

@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 29, 2026
stevsmit
stevsmit reviewed Jan 29, 2026
View reviewed changes
@stevsmit stevsmit removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 29, 2026
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2026

New changes are detected. LGTM label has been removed.

bjahagir-OpenShift
bjahagir-OpenShift commented Jan 30, 2026
View reviewed changes
Copy link
Contributor Author

@bjahagir-OpenShift bjahagir-OpenShift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented review comments from Steven

@bjahagir-OpenShift
Copy link
Contributor Author

bjahagir-OpenShift commented Jan 30, 2026

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Jan 30, 2026
@stevsmit stevsmit added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Jan 30, 2026
@stevsmit stevsmit removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 30, 2026
@stevsmit stevsmit added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Jan 30, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2026

@bjahagir-OpenShift: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@stevsmit stevsmit merged commit 2e64e11 into openshift:main Jan 30, 2026
2 checks passed
@stevsmit
Copy link
Member

stevsmit commented Jan 30, 2026

/cherry-pick enterprise-4.21

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Jan 30, 2026

@stevsmit: new pull request created: #105749

Details

In response to this:

/cherry-pick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stevsmit stevsmit stevsmit left review comments

Assignees

@mmakwana30 mmakwana30

Labels

branch/enterprise-4.21 merge-review-in-progress Signifies that the merge review team is reviewing this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

OCP 4.21 GA

Development

Successfully merging this pull request may close these issues.

5 participants

@bjahagir-OpenShift @ocpdocs-previewbot @mmakwana30 @stevsmit @openshift-cherrypick-robot