Conversation
CDO is being decommissioned fleet-wide. Remove all CDO-related configuration from managed-cluster-config: - dedicated-admin ClusterRole for CustomDomain resources - CDO namespace from managed-namespaces list - CDO rebalancer RoleBinding and infraPodsMisscheduled reference - CDO ServiceAccount (AWS) - CDO namespace from ownerref cleanup CronJob - CDO from OLM and PKO recording rule PromQL regexes - All CDO entries from managed resources allowlist - Regenerated hack/ templates Co-authored-by: Cursor <cursoragent@cursor.com>
openshift-ci-robot
added
the
jira/valid-reference
|
@aliceh: This pull request references ROSAENG-66154 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (12)
💤 Files with no reviewable changes (9)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe change removes the custom domains operator from deployment resources, service accounts, RBAC, namespace management, cleanup jobs, pod rebalancing, and operator observability rules. ChangesCustom domains operator removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change removes deprecated custom-domains-operator configuration and regenerates the related templates; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only deployment manifests, generated YAML templates, an OWNERS file, and documentation. The exact HEAD^..HEAD diff adds no Ginkgo title calls or dynamic test-title expressions, and no test-like paths changed. Therefore, it introduces no unstable or overly-specific test name. Full details: Test Structure And QualityExplanation PASS: The pull request changes only YAML, template, OWNERS, and README files. The parent-to-HEAD diff contains no test-like paths, Ginkgo constructs, or Gomega assertions. Therefore the stated Ginkgo test quality requirements are not applicable. Full details: Microshift Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The commit changes only YAML, template, and Markdown files, and the diff contains no new Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS — The pull request adds no Ginkgo e2e tests. The diff contains only deletions or modifications to YAML, Markdown, and generated template files. No changed path is a test source path, and no added line contains Full details: Topology-Aware Scheduling CompatibilityExplanation The PR introduces no topology-sensitive scheduling constraint. The diff against Full details: Ote Binary Stdout ContractExplanation PASS: The pull request changes only YAML, Markdown, and generated template configuration. The repository has no tracked Go files, and searches found no OTE process entry points or logging calls. The diff adds no stdout writes in main or suite setup. The embedded CronJob shell changes are not OTE binary process code. Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request adds no Ginkgo e2e tests. The parent-to-HEAD diff changes only deployment configuration, templates, resource lists, and documentation; all changed paths were classified as non-test. No added lines contain Ginkgo declarations, IPv4 literals, or external connectivity indicators. The compatibility check is therefore not applicable. Full details: No-Weak-CryptoExplanation The pull request introduces no weak-crypto usage. The exact added-line scan found no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, crypto API, HMAC, or constant-time comparison patterns. The changes delete CDO configuration and remove namespace/operator names from YAML, shell lists, PromQL allowlists, and generated templates. Existing MD5/SHA-1 text in generated templates is unchanged and appears in comments. Full details: Container-PrivilegesExplanation PASS: The PR diff only deletes CDO resources or removes CDO names from existing configurations. Added lines update namespace lists and PromQL allowlists. No added manifest content sets Full details: No-Sensitive-Data-In-LogsExplanation PASS — The PR does not add or broaden sensitive-data logging. The diff removes the CDO namespace from the rebalancer and owner-reference cleanup lists, and the logging statements remain unchanged. Diff scans found no added ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: aliceh The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@aliceh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
Delete the osd-rebalance-infra-nodes RoleBinding targeting namespace openshift-custom-domains-operator. Phase 1 of the CDO decommission removed the CDO namespace from clusters without the keep-label. The rebalancer SSS still tries to apply this RoleBinding to that namespace, causing ClusterSync failure on hibernation resume and blocking LS auto-clear. This is the minimal fix extracted from PR #2869 (full MCC cleanup) which is still under review. Co-authored-by: Cursor <cursoragent@cursor.com>
3 participants
Summary
Note: The app-interface SaaS file and labeller cronjob are intentionally retained — they are still needed for spb/spb-dev clusters.
Test plan
openshift-custom-domains-operatorcustom-domains-operatorin PromQL regexesMade with Cursor
Summary by CodeRabbit
Removed Components
Configuration Updates