Skip to content

Conversation

@vimauro
Copy link

@vimauro vimauro commented Jan 19, 2026

Summary

This PR extends the TNA (Two-Node Arbiter) cluster support to include platform: none in addition to the existing platform: baremetal support.

  • Added platform: none support for TNA (Two-Node Arbiter) clusters
  • Extended arbiter validation to accept both baremetal and none platforms
  • Skip BareMetal-specific asset generation (Machine API objects, BareMetalHost CRs) for none platform

Tests

  • Added TestArbiterInstallNonePlatform to verify arbiter generation succeeds for none platform without generating BareMetal-specific files
  • Added TestValidateArbiter with comprehensive test cases covering:
  • Valid none and baremetal platforms
  • Invalid platform (AWS) rejection

Validations

Validated locally by using kcli with a custom built payload that supports TNA (from karmab/kcli#850 )

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@vimauro: This pull request references OCPEDGE-2277 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR extends the TNA (Two-Node Arbiter) cluster support to include platform: none in addition to the existing platform: baremetal support.

  • Added platform: none support for TNA (Two-Node Arbiter) clusters
  • Extended arbiter validation to accept both baremetal and none platforms
  • Skip BareMetal-specific asset generation (Machine API objects, BareMetalHost CRs) for none platform

Tests

  • Added TestArbiterInstallNonePlatform to verify arbiter generation succeeds for none platform without generating BareMetal-specific files
  • Added TestValidateArbiter with comprehensive test cases covering:
  • Valid none and baremetal platforms
  • Invalid platform (AWS) rejection

ToDo

  • Validation via ClusterBot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@vimauro vimauro changed the title OCPEDGE-2277: Add support for platform None in TNA (Two-Node Arbiter) clusters OCPEDGE-2276: Add support for platform None in TNA (Two-Node Arbiter) clusters Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2026

@vimauro: This pull request references OCPEDGE-2276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR extends the TNA (Two-Node Arbiter) cluster support to include platform: none in addition to the existing platform: baremetal support.

  • Added platform: none support for TNA (Two-Node Arbiter) clusters
  • Extended arbiter validation to accept both baremetal and none platforms
  • Skip BareMetal-specific asset generation (Machine API objects, BareMetalHost CRs) for none platform

Tests

  • Added TestArbiterInstallNonePlatform to verify arbiter generation succeeds for none platform without generating BareMetal-specific files
  • Added TestValidateArbiter with comprehensive test cases covering:
  • Valid none and baremetal platforms
  • Invalid platform (AWS) rejection

ToDo

  • Validation via ClusterBot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vimauro vimauro marked this pull request as ready for review January 23, 2026 11:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@openshift-ci openshift-ci bot requested review from jhixson74 and tthvo January 23, 2026 11:16
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2026

@vimauro: This pull request references OCPEDGE-2276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR extends the TNA (Two-Node Arbiter) cluster support to include platform: none in addition to the existing platform: baremetal support.

  • Added platform: none support for TNA (Two-Node Arbiter) clusters
  • Extended arbiter validation to accept both baremetal and none platforms
  • Skip BareMetal-specific asset generation (Machine API objects, BareMetalHost CRs) for none platform

Tests

  • Added TestArbiterInstallNonePlatform to verify arbiter generation succeeds for none platform without generating BareMetal-specific files
  • Added TestValidateArbiter with comprehensive test cases covering:
  • Valid none and baremetal platforms
  • Invalid platform (AWS) rejection

Updated:

Validations

Validated locally by using kcli with a custom built payload that supports TNA (from karmab/kcli#850 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 23, 2026

@vimauro: This pull request references OCPEDGE-2276 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

This PR extends the TNA (Two-Node Arbiter) cluster support to include platform: none in addition to the existing platform: baremetal support.

  • Added platform: none support for TNA (Two-Node Arbiter) clusters
  • Extended arbiter validation to accept both baremetal and none platforms
  • Skip BareMetal-specific asset generation (Machine API objects, BareMetalHost CRs) for none platform

Tests

  • Added TestArbiterInstallNonePlatform to verify arbiter generation succeeds for none platform without generating BareMetal-specific files
  • Added TestValidateArbiter with comprehensive test cases covering:
  • Valid none and baremetal platforms
  • Invalid platform (AWS) rejection

Validations

Validated locally by using kcli with a custom built payload that supports TNA (from karmab/kcli#850 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vimauro
Copy link
Author

vimauro commented Jan 23, 2026

/verified by @vimauro Validated locally by using kcli with a custom built payload that supports TNA (from karmab/kcli#850 )

@vimauro
Copy link
Author

vimauro commented Jan 23, 2026

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

@vimauro: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images bb7d56e link true /test images
ci/prow/e2e-aws-ovn bb7d56e link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@tthvo
Copy link
Member

tthvo commented Jan 23, 2026

/verified by @vimauro

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2026
@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 23, 2026
@openshift-ci-robot
Copy link
Contributor

@tthvo: This PR has been marked as verified by @vimauro.

Details

In response to this:

/verified by @vimauro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tthvo
Copy link
Member

tthvo commented Jan 23, 2026

/cc @sadasu @patrickdillon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants