-
Notifications
You must be signed in to change notification settings - Fork 1.5k
OCPBUGS-56770: Honor user-specified bootDiagnostics on Azure Stack Hub #10223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gpei: This pull request references Jira Issue OCPBUGS-56770, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@gpei: This pull request references Jira Issue OCPBUGS-56770, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
tthvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
I just have a quick code suggestion, but it looks good to me!
|
/cc @patrickdillon |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tthvo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…he mpool's bootDiagnostics field. If not configured, the Azure Stack Hub default is applied
403570d to
e7bd4ca
Compare
tthvo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
@gpei: This pull request references Jira Issue OCPBUGS-56770, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224 |
|
@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6baf5a0-f28e-11f0-8879-37f1826c8b9e-0 |
|
/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224 |
|
@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/822ffbf0-f29f-11f0-8ca9-b7ffda14daa4-0 |
|
/test e2e-azure-ovn |
|
/test e2e-azure-ovn-shared-vpc |
|
/payload-abort |
|
/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224 |
|
@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dd7623a0-f2a8-11f0-8379-1d50ae9761e2-0 |
|
/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 #10224 |
|
@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16ae9c30-f2c0-11f0-9691-9788cda04eb1-0 |
|
The |
|
During the testing in openshift/release#73625, it turns out that the Machine API provider is reading the diagnostics config but not applying it to the worker VM, which is tracked in https://issues.redhat.com/browse/OCPBUGS-74076. /verified by @gpei |
|
@gpei: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@gpei: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6172692
into
openshift:main
|
@gpei: Jira Issue Verification Checks: Jira Issue OCPBUGS-56770 Jira Issue OCPBUGS-56770 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in accepted release 4.22.0-0.nightly-2026-01-21-055002 |
Fixed issue where user-specified
bootDiagnosticsconfiguration was ignored on Azure Stack Hub.The fix checks whether the user has explicitly configured bootDiagnostics via either defaultMachinePlatform.bootDiagnostics or the machine pool's bootDiagnostics field. If configured, the user's settings are respected. If not configured, the Azure Stack Hub default is applied.