Skip to content

Conversation

@gpei
Copy link
Contributor

@gpei gpei commented Jan 15, 2026

Fixed issue where user-specified bootDiagnostics configuration was ignored on Azure Stack Hub.

The fix checks whether the user has explicitly configured bootDiagnostics via either defaultMachinePlatform.bootDiagnostics or the machine pool's bootDiagnostics field. If configured, the user's settings are respected. If not configured, the Azure Stack Hub default is applied.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-56770, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixed issue where user-specified bootDiagnostics configuration was ignored on Azure Stack Hub.

The fix checks whether the user has explicitly configured bootDiagnostics via either defaultMachinePlatform.bootDiagnostics or the machine pool's bootDiagnostics field. If configured, the user's settings are respected. If not configured, the Azure Stack Hub default is applied, maintaining backward compatibility for existing clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gpei
Copy link
Contributor Author

gpei commented Jan 15, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 15, 2026
@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-56770, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 15, 2026
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

I just have a quick code suggestion, but it looks good to me!

@tthvo
Copy link
Member

tthvo commented Jan 15, 2026

/cc @patrickdillon

@openshift-ci openshift-ci bot requested a review from patrickdillon January 15, 2026 21:24
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tthvo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2026
…he mpool's bootDiagnostics field. If not configured, the Azure Stack Hub default is applied
@gpei gpei force-pushed the fix-OCPBUGS-56770 branch from 403570d to e7bd4ca Compare January 16, 2026 00:43
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2026
@openshift-ci-robot
Copy link
Contributor

@gpei: This pull request references Jira Issue OCPBUGS-56770, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jinyunma

Details

In response to this:

Fixed issue where user-specified bootDiagnostics configuration was ignored on Azure Stack Hub.

The fix checks whether the user has explicitly configured bootDiagnostics via either defaultMachinePlatform.bootDiagnostics or the machine pool's bootDiagnostics field. If configured, the user's settings are respected. If not configured, the Azure Stack Hub default is applied.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d6baf5a0-f28e-11f0-8879-37f1826c8b9e-0

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/822ffbf0-f29f-11f0-8ca9-b7ffda14daa4-0

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/test e2e-azure-ovn

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/test e2e-azure-ovn-shared-vpc

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/payload-abort

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@gpei: aborted 1 active payload job(s) for pull request #10223

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28 #10224

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-disabled-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dd7623a0-f2a8-11f0-8379-1d50ae9761e2-0

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

/payload-job-with-prs periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 #10224

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 16, 2026

@gpei: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16ae9c30-f2c0-11f0-9691-9788cda04eb1-0

@gpei
Copy link
Contributor Author

gpei commented Jan 16, 2026

The periodic-ci-openshift-verification-tests-main-installation-nightly-4.22-azure-stack-ipi-boot-diagnostics-usermanaged-f28 job failed for an environment variable issue, fixing and testing in openshift/release#73625

@gpei
Copy link
Contributor Author

gpei commented Jan 19, 2026

During the testing in openshift/release#73625, it turns out that the Machine API provider is reading the diagnostics config but not applying it to the worker VM, which is tracked in https://issues.redhat.com/browse/OCPBUGS-74076.
From installer side, it's setting the bootDiagnostics related options for bootstrap/master machines, CPMS/MachineSet correctly, so adding verified label.

/verified by @gpei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jan 19, 2026
@openshift-ci-robot
Copy link
Contributor

@gpei: This PR has been marked as verified by @gpei.

Details

In response to this:

During the testing in openshift/release#73625, it turns out that the Machine API provider is reading the diagnostics config but not applying it to the worker VM, which is tracked in https://issues.redhat.com/browse/OCPBUGS-74076.
From installer side, it's setting the bootDiagnostics related options for bootstrap/master machines, CPMS/MachineSet correctly, so adding verified label.

/verified by @gpei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2026

@gpei: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azurestack e7bd4ca link false /test e2e-azurestack

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 19e1579 and 2 for PR HEAD e7bd4ca in total

@openshift-merge-bot openshift-merge-bot bot merged commit 6172692 into openshift:main Jan 19, 2026
19 of 20 checks passed
@openshift-ci-robot
Copy link
Contributor

@gpei: Jira Issue Verification Checks: Jira Issue OCPBUGS-56770
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-56770 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Fixed issue where user-specified bootDiagnostics configuration was ignored on Azure Stack Hub.

The fix checks whether the user has explicitly configured bootDiagnostics via either defaultMachinePlatform.bootDiagnostics or the machine pool's bootDiagnostics field. If configured, the user's settings are respected. If not configured, the Azure Stack Hub default is applied.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-01-21-055002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants