HIVE-3074: VSphere preflight check uses hive trusted CA bundle#2853
HIVE-3074: VSphere preflight check uses hive trusted CA bundle#28532uasimojo wants to merge 1 commit intoopenshift:masterfrom
Conversation
For VSphere, when we set up to run the installer, we install the generated hive-trusted-cabundle as well as the configured VCenter certs. However, we weren't doing the former for the preflight authn check. Fix. (This only seems to matter under particular network configurations around the VCenter, which are apparently quite rare given we only recently encountered problems in this space.)
openshift-ci-robot
added
the
jira/valid-reference
|
@2uasimojo: This pull request references HIVE-3074 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-vsphere |
May want to consider putting this file in a path with |
|
@2uasimojo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2853 +/- ##
==========================================
- Coverage 50.33% 50.32% -0.02%
==========================================
Files 280 280
Lines 34288 34296 +8
==========================================
Hits 17258 17258
- Misses 15669 15677 +8
Partials 1361 1361
🚀 New features to boost your workflow:
|
2 participants
For VSphere, when we set up to run the installer, we install the generated hive-trusted-cabundle as well as the configured VCenter certs. However, we weren't doing the former for the preflight authn check. Fix.
(This only seems to matter under particular network configurations around the VCenter, which are apparently quite rare given we only recently encountered problems in this space.)