Skip to content

[HIVE-2944] Make the cluster in e2e-pool use legacy deprovision#2843

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
suhanime:HIVE-2944
Mar 3, 2026
Merged

[HIVE-2944] Make the cluster in e2e-pool use legacy deprovision#2843
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
suhanime:HIVE-2944

Conversation

@suhanime
Copy link
Contributor

@suhanime suhanime commented Feb 5, 2026

As a part of AWS SDK v2 migration, installer changed some of the fields populated by the destroyer builder that diverges from our existing destroy flow. Add an annotation for legacy deprovision on a cd created by e2e pool, to ensure both deprovision paths work as expected.

Also capture deprovision pod yaml

@openshift-ci openshift-ci bot requested review from 2uasimojo and dlom February 5, 2026 07:10
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2026
@suhanime
Copy link
Contributor Author

suhanime commented Feb 5, 2026

/test e2e-pool

@2uasimojo
Copy link
Member

See HIVE-3069 for the security fail.

The e2e-pool fail looks like we're timing out deprovisioning... which is exactly what we would expect if legacy deprovision isn't working. But we don't have good FFDC for that yet. Suggest adding collection of

  • ClusterDeprovisionz here
  • deprov pod logs here.

@suhanime suhanime force-pushed the HIVE-2944 branch 2 times, most recently from a896275 to 58f1360 Compare February 19, 2026 16:55
As a part of AWS SDK v2 migration, installer changed some of the fields
populated by the destroyer builder that diverges from our existing
destroy flow. Add an annotation for legacy deprovision on a cd
created by e2e pool, to ensure both deprovision paths work as expected.

Also capture deprovision pod yaml
@2uasimojo
Copy link
Member

/lgtm
/override ci/prow/security
/test hive-mce-27-on-pull-request
/test hive-mce-28-on-pull-request

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2026
@openshift openshift deleted a comment from openshift-ci bot Mar 2, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2026

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/lgtm
/override ci/prow/security
/test hive-mce-27-on-pull-request
/test hive-mce-28-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member

/test hive-mce-27-on-pull-request

/test hive-mce-28-on-pull-request

@openshift openshift deleted a comment from openshift-ci bot Mar 2, 2026
@2uasimojo
Copy link
Member

/test hive-mce-28-on-pull-request

@openshift openshift deleted a comment from openshift-ci bot Mar 2, 2026
@suhanime
Copy link
Contributor Author

suhanime commented Mar 3, 2026

/test hive-mce-27-on-pull-request

@openshift openshift deleted a comment from openshift-ci bot Mar 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@suhanime: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a5d0850 into openshift:master Mar 3, 2026
23 checks passed
@suhanime suhanime deleted the HIVE-2944 branch March 3, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants