Skip to content

fix(deps): update module gopkg.in/yaml.v2 to v3 - #582

Open
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gopkg.in-yaml.v2-3.x
Open

fix(deps): update module gopkg.in/yaml.v2 to v3#582
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gopkg.in-yaml.v2-3.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
gopkg.in/yaml.v2 v2.4.0v3.0.1 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

go-yaml/yaml (gopkg.in/yaml.v2)

v3.0.1

Compare Source

v3.0.0

Compare Source


Configuration

📅 Schedule: (in timezone UTC)

  • Branch creation
    • Between 02:00 AM and 04:59 AM, Monday through Friday (* 2-4 * * 1-5)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux Bot added area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Walkthrough

This PR changes production, controller test, and end-to-end YAML usage from gopkg.in/yaml.v2 to gopkg.in/yaml.v3. go.mod declares yaml.v3 directly and retains yaml.v2 as an indirect dependency.

Changes

YAML dependency migration

Layer / File(s) Summary
Dependency declarations
go.mod
The direct dependency changes to yaml.v3. yaml.v2 remains an indirect dependency.
YAML call-site migration
controllers/secret_controller.go, pkg/types/alertmanagerconfig.go, controllers/secret_controller_test.go, test/e2e/utils/utils.go
Existing production, controller test, and end-to-end YAML operations now use yaml.v3.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: smarthall, xiaoyu74

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML imports and go.mod. All actual Ginkgo titles are static literal strings with no generated, timestamped, node, namespace, IP, or UUID values.
Test Structure And Quality ✅ Passed The PR only changes YAML imports and go.mod; it does not modify Ginkgo It blocks, lifecycle hooks, cluster waits, or assertions.
Microshift Test Compatibility ✅ Passed The PR adds no Ginkgo e2e tests. The only test-related changes replace YAML imports, so no MicroShift-incompatible API or feature is introduced by a new test.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML imports and go.mod; it adds no Ginkgo e2e tests or multi-node assumptions. The changed test file contains standard Go Test functions only.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes YAML imports and go.mod entries; it adds no deployment manifests, replicas, affinity, topology spread, node selectors, tolerations, or PDB scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The OTE binary builds test/e2e only; its runner uses GinkgoConfiguration/RunSpecs, and suite output uses GinkgoWriter or GinkgoLogr. No process-level stdout write exists in the PR changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff adds no Ginkgo e2e tests or network behavior; it only changes YAML imports and go.mod requirements.
No-Weak-Crypto ✅ Passed The patch only changes YAML imports and module requirements; no weak-crypto APIs, algorithms, custom crypto, or secret/token comparisons were added.
Container-Privileges ✅ Passed The PR changes only Go YAML imports and go.mod; no changed container/Kubernetes manifest adds privilege settings, and the operator image uses USER 1001.
No-Sensitive-Data-In-Logs ✅ Passed The patch only changes YAML imports and go.mod entries; it adds no logging calls or log fields containing secrets, tokens, passwords, PII, or customer data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating direct YAML usage from gopkg.in/yaml.v2 to gopkg.in/yaml.v3.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/gopkg.in-yaml.v2-3.x

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from smarthall and xiaoyu74 June 26, 2026 04:23
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (1e20666) to head (265841e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #582   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files           8        8           
  Lines        1124     1124           
=======================================
  Hits          760      760           
  Misses        330      330           
  Partials       34       34           
Files with missing lines Coverage Δ
controllers/secret_controller.go 88.36% <ø> (ø)
pkg/types/alertmanagerconfig.go 52.38% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 8, 2026
@red-hat-konflux
red-hat-konflux Bot deleted the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch July 8, 2026 00:11
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed fix(deps): update module gopkg.in/yaml.v2 to v3 Jul 8, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 8, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch 2 times, most recently from 0426349 to 0bef794 Compare July 8, 2026 04:12
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed Jul 12, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 12, 2026
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed fix(deps): update module gopkg.in/yaml.v2 to v3 Jul 13, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 13, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch 3 times, most recently from 9a951e6 to 673e73e Compare July 15, 2026 04:14
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign bergmannf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed Jul 26, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 26, 2026
@red-hat-konflux red-hat-konflux Bot changed the title fix(deps): update module gopkg.in/yaml.v2 to v3 - autoclosed fix(deps): update module gopkg.in/yaml.v2 to v3 Jul 27, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 27, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch 2 times, most recently from 673e73e to 91d549c Compare July 27, 2026 04:15
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gopkg.in-yaml.v2-3.x branch from 91d549c to 265841e Compare August 4, 2026 04:18
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate 265841e link true /test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nephomaniac

Copy link
Copy Markdown
Contributor

Superseded by #621 which includes this change plus additional dependency updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant