Skip to content

chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - #580

Open
red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x
Open

red-hat-konflux[bot] wants to merge 1 commit into
masterfrom
konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x

Conversation

@red-hat-konflux

@red-hat-konflux red-hat-konflux Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
gomodules.xyz/jsonpatch/v2 v2.5.0v3.0.1 age confidence

Warning

Some dependencies could not be looked up. Check the Dependency Dashboard for more information.


Release Notes

gomodules/jsonpatch (gomodules.xyz/jsonpatch/v2)

v3.0.1

Compare Source

This release uses our forked gomodules/orderedmap library. Our forked version has 2 major changes:

  • Uses *OrderedMap instead of OrderedMap inside nested orderedmaps.
  • I ported unstructured helpers from Kubernetes to work with orderedmaps.

v3.0.0

Compare Source

This release uses iancoleman/orderedmap to generate predictable patch. This is very useful if the generated patch is checked into a VCS like git.


Configuration

📅 Schedule: (in timezone UTC)

  • Branch creation
    • Between 02:00 AM and 04:59 AM, Monday through Friday (* 2-4 * * 1-5)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

To execute skipped test pipelines write comment /ok-to-test.


Documentation

Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.

@red-hat-konflux red-hat-konflux Bot added area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

The indirect gomodules.xyz/jsonpatch/v2 dependency in go.mod is downgraded from v2.5.0 to v2.4.0.

Changes

Dependency Downgrade

Layer / File(s) Summary
Downgrade jsonpatch requirement
go.mod
The indirect gomodules.xyz/jsonpatch/v2 requirement changes from v2.5.0 to v2.4.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: robotmaxtron, bergmannf


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name Status Explanation Resolution
Ote Binary Stdout Contract ❌ Error fips.go init() calls fmt.Println, which writes non-JSON text to stdout in process-level code. Replace fmt.Println in fips.go with an os.Stderr write, or route the message through logging configured for stderr.
Title check ⚠️ Warning The title states an update to v3, but the changeset downgrades gomodules.xyz/jsonpatch/v2 from v2.5.0 to v2.4.0. Change the title to describe the actual dependency change, such as downgrading gomodules.xyz/jsonpatch/v2 from v2.5.0 to v2.4.0.
✅ Passed checks (13 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only go.mod and go.sum; no Ginkgo test files or test titles were added or modified.
Test Structure And Quality ✅ Passed The PR changes only go.mod and go.sum; it adds or modifies no Ginkgo test code, so these test-structure requirements have no applicable findings.
Microshift Test Compatibility ✅ Passed The commit changes only go.mod and go.sum; no Go or Ginkgo test files or test declarations were added, so the MicroShift test check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only go.mod and go.sum; it adds no Ginkgo e2e tests or other test code requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only go.mod and go.sum for jsonpatch; no deployment manifests, operator code, controllers, or scheduling constraints are added or modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only go.mod and go.sum. It adds no Ginkgo e2e tests or network operations, so this check is not applicable.
No-Weak-Crypto ✅ Passed The PR changes only jsonpatch dependency metadata in go.mod/go.sum; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or new secret comparison appears in the patch.
Container-Privileges ✅ Passed The PR changes only go.mod and go.sum. No privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or privilege-escalation settings were added.
No-Sensitive-Data-In-Logs ✅ Passed The patch changes only go.mod and go.sum dependency metadata; it adds no logging code or sensitive data output.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bergmannf and robotmaxtron June 24, 2026 04:21
@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.61%. Comparing base (c84d2f2) to head (e2f8efb).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #580   +/-   ##
=======================================
  Coverage   67.61%   67.61%           
=======================================
  Files           8        8           
  Lines        1124     1124           
=======================================
  Hits          760      760           
  Misses        330      330           
  Partials       34       34           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch from 754756a to 9299b69 Compare June 26, 2026 04:19
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Jul 2, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 2, 2026
@red-hat-konflux
red-hat-konflux Bot deleted the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch July 2, 2026 04:17
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Jul 3, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 3, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch 2 times, most recently from 9299b69 to 49bd389 Compare July 3, 2026 04:18
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Jul 12, 2026
@red-hat-konflux red-hat-konflux Bot closed this Jul 12, 2026
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Jul 13, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Jul 13, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch 3 times, most recently from 5768003 to d5c97fc Compare July 15, 2026 04:14
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Aug 3, 2026
@red-hat-konflux red-hat-konflux Bot closed this Aug 3, 2026
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Aug 4, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Aug 4, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch 2 times, most recently from d5c97fc to 2d31841 Compare August 4, 2026 04:17
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed Aug 4, 2026
@red-hat-konflux red-hat-konflux Bot closed this Aug 4, 2026
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
@red-hat-konflux red-hat-konflux Bot changed the title chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 - autoclosed chore(deps): update module gomodules.xyz/jsonpatch/v2 to v3 Aug 5, 2026
@red-hat-konflux red-hat-konflux Bot reopened this Aug 5, 2026
@red-hat-konflux
red-hat-konflux Bot force-pushed the konflux/mintmaker/master/gomodules.xyz-jsonpatch-v2-3.x branch 2 times, most recently from 2d31841 to e2f8efb Compare August 5, 2026 04:14
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign tnierman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: red-hat-konflux[bot]
Once this PR has been reviewed and has the lgtm label, please assign tnierman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephomaniac

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/validate e2f8efb link true /test validate

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@nephomaniac

Copy link
Copy Markdown
Contributor

This change is a downgrade (jsonpatch v2.5.0 → v2.4.0), not an upgrade. Mintmaker appears confused. Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issues or PRs related to dependency changes major-update manual-review-required ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant