chore(deps): update module github.com/twmb/franz-go/pkg/kmsg to v2 - #579
Conversation
WalkthroughThe ChangesDependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 117: The go.mod file has been updated to replace the indirect dependency
kmsg v1.13.1 with kmsg/v2 v2.0.1, but go.sum needs to be synchronized with this
change. Run go mod tidy to update go.sum and remove the old kmsg v1.13.1 entries
while adding the new kmsg/v2 v2.0.1 entries. Additionally, verify and document
in the commit message or pull request why this major version bump upgrade is
necessary, such as whether it is required by another dependency upgrade,
addresses a security concern, or provides needed functionality. If this is a
routine automated dependency update without clear functional benefits, consider
whether the maintenance burden justifies upgrading a transitive dependency.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: e21eff83-24b7-4d09-8c56-76429d716ac2
📒 Files selected for processing (1)
go.mod
6b386b9 to
a111ef5
Compare
a111ef5 to
87a7347
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
87a7347 to
cc68321
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Module path change (franz-go/kmsg v1 → v2) on an indirect dep. Upstream transitive deps haven't migrated — will break the build. |
This PR contains the following updates:
v1.13.1→v2.0.1Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Configuration
📅 Schedule: (in timezone UTC)
* 2-4 * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.