chore(deps): update module go.yaml.in/yaml/v2 to v3 - #571
red-hat-konflux[bot] wants to merge 1 commit into
Conversation
WalkthroughThe PR updates the indirect ChangesYAML dependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/retest |
55ba64d to
b56ffd7
Compare
b56ffd7 to
70d668e
Compare
70d668e to
19cdaa7
Compare
19cdaa7 to
8404bc2
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 133: Update the google.golang.org/grpc dependency in go.mod to v1.82.1 or
later, then refresh go.sum so the dependency checksums match the new version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 61245d22-2e09-441e-8d30-c0f665b495e0
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod
| go.uber.org/zap v1.28.0 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.5 // indirect |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the relevant section of go.mod with line numbers
cat -n go.mod | sed -n '120,170p'
# Search for grpc references in the module files
rg -n "google\.golang\.org/grpc|v1\.82\.0|v1\.82\.1" go.mod go.sumRepository: openshift/configure-alertmanager-operator
Length of output: 2828
🌐 Web query:
GO-2026-6061 google.golang.org/grpc v1.82.1 xDS RBAC authorization bypass HTTP/2 denial of service OSV
💡 Result:
GO-2026-6061 is a security advisory for the google.golang.org/grpc package, which addresses three distinct vulnerabilities fixed in version v1.82.1 [1][2][3]. These vulnerabilities involve the xDS RBAC authorization engine and the HTTP/2 transport implementation [1][4]. The vulnerabilities are as follows: 1. xDS RBAC Authorization Bypass (Fail-Open): When building RBAC policies from xDS configurations, the engine previously ignored unsupported rule types, specifically Metadata and RequestedServerName [5][4]. If an authorization policy relied on these matchers, they were treated as no-ops, effectively removing the intended security restrictions [5][6]. 2. xDS RBAC Denial of Service (Panic): The system was vulnerable to a server panic when parsing specifically crafted xDS RBAC policies that contained NOT rules wrapping unsupported field types [5][4]. A recursive call for the inner rule could return a nil matcher, leading to a pointer dereference error and server crash upon processing incoming requests [5][7]. 3. HTTP/2 Denial of Service (Mitigation Bypass): An HTTP/2 Rapid Reset mitigation bypass allowed for denial of service [3][4]. Attackers could initiate a rapid flood of HEADERS frames followed immediately by RST_STREAM frames [4]. Because these items were queued in the control buffer without correctly counting against the transport's response frame threshold, they could bypass reader blocking and cause high CPU consumption [4][7]. The resolution, released in v1.82.1, includes explicit handling for the missing xDS rule types to prevent silent authorization bypasses, fixes to the recursive matcher logic to avoid null pointer dereferences, and a new mechanism to throttle incoming HTTP/2 frames [5][4]. Users can adjust this new HTTP/2 throttling behavior using the GRPC_GO_EXPERIMENTAL_CONTROL_BUFFER_THROTTLE_LIMIT environment variable [4][6]. Updates should be applied by upgrading the google.golang.org/grpc module to v1.82.1 or later [5][3].
Citations:
- 1: https://pkg.go.dev/vuln/GO-2026-6061
- 2: https://osv.dev/vulnerability/GO-2026-6061
- 3: https://gist.github.com/alon710/8c872c1eb4b16092be73ac55abf265f9
- 4: fix(deps): update module google.golang.org/grpc to v1.82.1 [security] - abandoned google/osv.dev#5699
- 5: https://securelayer7.net/lab/grpc-go-xds-rbac-auth-bypass-rapid-reset-dos-not-rule-panic
- 6: Update module google.golang.org/grpc to v1.82.1 [SECURITY] GoogleCloudPlatform/opentelemetry-operations-go#1184
- 7: fix(security/unknown/): update module google.golang.org/grpc to v1.83.1 [security] grafana/loki-release#385
Upgrade the gRPC pin in go.mod:147.
google.golang.org/grpc v1.82.0 is still pinned here; GO-2026-6061 affects versions before v1.82.1. Bump to v1.82.1 or later and refresh go.sum.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@go.mod` at line 133, Update the google.golang.org/grpc dependency in go.mod
to v1.82.1 or later, then refresh go.sum so the dependency checksums match the
new version.
Sources: Path instructions, Linters/SAST tools
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
8404bc2 to
17b6a17
Compare
|
/retest |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 67.61% 67.61%
=======================================
Files 8 8
Lines 1124 1124
=======================================
Hits 760 760
Misses 330 330
Partials 34 34 🚀 New features to boost your workflow:
|
|
@red-hat-konflux[bot]: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Indirect dep patch bump (go.yaml.in/yaml/v3). Requires rebase — 19 commits behind master, stale Konflux checks from removed tenant. |
This PR contains the following updates:
v2.4.4→v3.0.5Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
yaml/go-yaml (go.yaml.in/yaml/v2)
v3.0.5Compare Source
v3.0.4Compare Source
v3.0.3Compare Source
v3.0.2Compare Source
v3.0.1Compare Source
v3.0.0Compare Source
Configuration
📅 Schedule: (in timezone UTC)
* 2-4 * * 1-5)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.